llvm dev - Mar 2016 - Regression in SPEC2006/gcc caused by LoopLoadElimination

> On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com> wrote:
> 
> Hi Haicheng,
> 
> Sorry about the breakage.  I reverted it in r262839.
> 
> I will try to reproduce it locally.  Please don’t blow away your
directories yet in case I need further help.
OK, I managed to reproduce this locally.  Should be able to make progress from
here without further help from you.

Adam
> Thanks,
> Adam
> 
>> On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org
<mailto:haicheng at codeaurora.org>> wrote:
>> 
>> Hi Adam,
>>  
>> I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong
result (166.s) in AArch64 when running with *ref* data set.  The error happens
when I use either “-Ofast -flto -fuse-ld=gold” or “-O3 -fno-strict-aliasing”. 
Please let me know if you need more information.
>>  
>> Best,
>>  
>> Haicheng
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160307/b59c2232/attachment.html>

I’ve committed the fix in r263058.  Haicheng, Eric/Benjamin, can you guys please
give it a test with your codebase.  (You need to enable the pass with -mllvm
-enable-loop-load-elim.)

Thanks!
Adam
> On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com> wrote:
> 
> 
>> On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com
<mailto:anemet at apple.com>> wrote:
>> 
>> Hi Haicheng,
>> 
>> Sorry about the breakage.  I reverted it in r262839.
>> 
>> I will try to reproduce it locally.  Please don’t blow away your
directories yet in case I need further help.
> 
> OK, I managed to reproduce this locally.  Should be able to make progress
from here without further help from you.
> 
> Adam
> 
>> Thanks,
>> Adam
>> 
>>> On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at
codeaurora.org <mailto:haicheng at codeaurora.org>> wrote:
>>> 
>>> Hi Adam,
>>>  
>>> I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate
wrong result (166.s) in AArch64 when running with *ref* data set.  The error
happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3
-fno-strict-aliasing”.  Please let me know if you need more information.
>>>  
>>> Best,
>>>  
>>> Haicheng
>> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160309/a19167d3/attachment.html>

Thank you, Adam.

 

It passes all the benchmarks I have.

 

Haicheng

 

From: anemet at apple.com [mailto:anemet at apple.com] 
Sent: Wednesday, March 09, 2016 7:17 PM
To: Haicheng Wu; Eric Christopher; Benjamin Kramer
Cc: llvm-dev
Subject: Re: Regression in SPEC2006/gcc caused by LoopLoadElimination

 

I’ve committed the fix in r263058.  Haicheng, Eric/Benjamin, can you guys please
give it a test with your codebase.  (You need to enable the pass with -mllvm
-enable-loop-load-elim.)

 

Thanks!

Adam

 

On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com
<mailto:anemet at apple.com> > wrote:

 

 

On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com <mailto:anemet
at apple.com> > wrote:

 

Hi Haicheng,

 

Sorry about the breakage.  I reverted it in r262839.

 

I will try to reproduce it locally.  Please don’t blow away your directories yet
in case I need further help.

 

OK, I managed to reproduce this locally.  Should be able to make progress from
here without further help from you.

 

Adam





Thanks,

Adam

 

On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org
<mailto:haicheng at codeaurora.org> > wrote:

 

Hi Adam,

 

I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong result
(166.s) in AArch64 when running with *ref* data set.  The error happens when I
use either “-Ofast -flto -fuse-ld=gold” or “-O3 -fno-strict-aliasing”.  Please
let me know if you need more information.

 

Best,

 

Haicheng

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160310/7a8cc9d8/attachment.html>

On Thu, Mar 10, 2016 at 1:17 AM, Adam Nemet <anemet at apple.com>
wrote:
> I’ve committed the fix in r263058.  Haicheng, Eric/Benjamin, can you guys
> please give it a test with your codebase.  (You need to enable the pass
with
> -mllvm -enable-loop-load-elim.)
The miscompilation I was seeing is gone now, too. Thanks!
> On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com> wrote:
>
>
> On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com> wrote:
>
> Hi Haicheng,
>
> Sorry about the breakage.  I reverted it in r262839.
>
> I will try to reproduce it locally.  Please don’t blow away your
directories
> yet in case I need further help.
>
>
> OK, I managed to reproduce this locally.  Should be able to make progress
> from here without further help from you.
>
> Adam
>
> Thanks,
> Adam
>
> On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org>
wrote:
>
> Hi Adam,
>
> I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong
> result (166.s) in AArch64 when running with *ref* data set.  The error
> happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3
> -fno-strict-aliasing”.  Please let me know if you need more information.
>
> Best,
>
> Haicheng
>
>
>
>