Owen Anderson
2015-May-26 20:46 UTC
[LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
> On May 26, 2015, at 1:37 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: > >> >> On 2015-May-26, at 09:46, Alex L <arphaman at gmail.com> wrote: >> >> Hi all, >> >> The CodeGen library is a big bag of interdependent bits. This caused >> a circular dependency in the MIR serialization commit (r237954), which got >> reverted in r238007. >> >> I propose separating the machine IR out of CodeGen and into its own >> MIR library, living at lib/MIR. This touches every target but it's mostly a >> mechanical change that renames the header files, although a couple of pre-rename >> commits are needed to decouple several things in CodeGen. I've attached a proof >> of concept patch that renames the files and applies cleanly to r238038. >> >> The MIR serialization code will go under the new MIR library and not under >> CodeGen which will break the dependency. The CodeGen library will link MIR >> automatically so the build files for tools that link with CodeGen won't have to >> be changed. >> >> Thanks for reading, >> Alex >> > > FWIW, I'm in favour of this. I'd be interested to hear if there's > a reason *not* to do this. > > Here's some more context: > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html <http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html>I have no objections, though I think lib/MachineIR would make a prettier bikeshed ;-) —Owen -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150526/fd523047/attachment.html>
Chris Lattner
2015-May-27 04:28 UTC
[LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
On May 26, 2015, at 1:46 PM, Owen Anderson <resistor at mac.com> wrote:>>> The MIR serialization code will go under the new MIR library and not under >>> CodeGen which will break the dependency. The CodeGen library will link MIR >>> automatically so the build files for tools that link with CodeGen won't have to >>> be changed. >>> >>> Thanks for reading, >>> Alex >>> >> >> FWIW, I'm in favour of this. I'd be interested to hear if there's >> a reason *not* to do this. >> >> Here's some more context: >> >> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html <http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html> > I have no objections, though I think lib/MachineIR would make a prettier bikeshed ;-)+1. Codegen should also be renamed to something else that starts with “Machine” as well. -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150526/17785cb2/attachment.html>
Quentin Colombet
2015-May-27 06:20 UTC
[LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
+1. Could those two be subdirectories of one “Machine-Related-Stuff” directory? E.g., MachineStuff/IR MachineStuff/CodeGen Where MachineStuff is something meaningful :). That way, they keep a logic bound, more formal than the naming convention. My 2c. Q.> On May 26, 2015, at 9:28 PM, Chris Lattner <clattner at apple.com> wrote: > > On May 26, 2015, at 1:46 PM, Owen Anderson <resistor at mac.com <mailto:resistor at mac.com>> wrote: >>>> The MIR serialization code will go under the new MIR library and not under >>>> CodeGen which will break the dependency. The CodeGen library will link MIR >>>> automatically so the build files for tools that link with CodeGen won't have to >>>> be changed. >>>> >>>> Thanks for reading, >>>> Alex >>>> >>> >>> FWIW, I'm in favour of this. I'd be interested to hear if there's >>> a reason *not* to do this. >>> >>> Here's some more context: >>> >>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html <http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150518/278031.html> >> I have no objections, though I think lib/MachineIR would make a prettier bikeshed ;-) > > +1. Codegen should also be renamed to something else that starts with “Machine” as well. > > -Chris > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150526/3c922c05/attachment.html>
Reid Kleckner
2015-May-27 17:13 UTC
[LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
On Tue, May 26, 2015 at 1:46 PM, Owen Anderson <resistor at mac.com> wrote:> > I have no objections, though I think lib/MachineIR would make a prettier > bikeshed ;-) >+1 for this. I think you probably want to limit the scope of your change to just splitting out MachineIR and not trying to rename CodeGen, AsmPrinter, etc. :) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150527/dbe63d6d/attachment.html>
Duncan P. N. Exon Smith
2015-May-27 17:22 UTC
[LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
> On 2015 May 27, at 10:13, Reid Kleckner <rnk at google.com> wrote: > > On Tue, May 26, 2015 at 1:46 PM, Owen Anderson <resistor at mac.com> wrote: > I have no objections, though I think lib/MachineIR would make a prettier bikeshed ;-) > > +1 for this. I think you probably want to limit the scope of your change to just splitting out MachineIR and not trying to rename CodeGen, AsmPrinter, etc. :)Agreed :). The rest seems out-of-scope for Alex's internship.
Maybe Matching Threads
- [LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
- [LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
- [LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
- [LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR
- [LLVMdev] RFC: Separate machine IR from lib/CodeGen into lib/MIR