On 8 January 2015 at 19:46, Chandler Carruth <chandlerc at google.com> wrote:> > On Thu, Jan 8, 2015 at 4:35 PM, Greg Fitzgerald <garious at gmail.com> wrote: >> >> How do you feel about adding LLD to the LLVM repo? Could it follow >> the same path as the integrated assembler? That is, Clang keeps it >> off by default for each architecture until it's ready for prime time. > > > While I'm not personally opposed to it, I think it's reasonable to avoid if > people want to not have the clutter of a linker when checking out and using > LLVM.If this ever happens, we *must* fix the coding style first. I would also list as must fix before: * check-all clean on a asan and msan build. * -DBUILD_SHARED_LIBS=ON works. Cheers, Rafael
> * fix the coding style first. > * check-all clean on a asan and msan build. > * -DBUILD_SHARED_LIBS=ON works.I can take the ASan/MSan and build work. Fixing the coding style is important, but must it be a gate? If so, can we push the patch for lowerCamelCase local variables in the LLVM coding conventions before there's a plan on how to transition the LLVM codebase? Thanks, Greg On Fri, Jan 9, 2015 at 4:22 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:> On 8 January 2015 at 19:46, Chandler Carruth <chandlerc at google.com> wrote: >> >> On Thu, Jan 8, 2015 at 4:35 PM, Greg Fitzgerald <garious at gmail.com> wrote: >>> >>> How do you feel about adding LLD to the LLVM repo? Could it follow >>> the same path as the integrated assembler? That is, Clang keeps it >>> off by default for each architecture until it's ready for prime time. >> >> >> While I'm not personally opposed to it, I think it's reasonable to avoid if >> people want to not have the clutter of a linker when checking out and using >> LLVM. > > If this ever happens, we *must* fix the coding style first. I would > also list as must fix before: > > * check-all clean on a asan and msan build. > * -DBUILD_SHARED_LIBS=ON works. > > Cheers, > Rafael
On Mon, Jan 12, 2015 at 4:07 PM, Greg Fitzgerald <garious at gmail.com> wrote:> > * fix the coding style first. > > * check-all clean on a asan and msan build. > > * -DBUILD_SHARED_LIBS=ON works. > > I can take the ASan/MSan and build work. Fixing the coding style is > important, but must it be a gate? If so, can we push the patch for > lowerCamelCase local variables in the LLVM coding conventions before > there's a plan on how to transition the LLVM codebase?Wait, huh? I didn't think there was *any* consensus that this was the desired path forward. I think Rafael was just listing things that would need to happen *if* it were the path forward. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150112/c0625336/attachment.html>