I've been implementing ELF/AArch64 support for lld. I can now successfully link and run a simple "Hello World" app for both dynamic and static linking. I'd like to upstream this implementation, but wanted to get feedback on how people might like to see it. Would people rather see the whole thing in one shot, each file individually or somehow break it down even farther? The implementation obviously requires all the files due to their interplay, so I'm not sure how only some files could be committed without the others. I don't yet have tests for everything; is it possible to upstream now or wait until I have a complete test suite in place as well? Trying to get feedback now to make the process as smooth as possible. Thanks, Daniel -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140731/678c645f/attachment.html>
Cool! Starting the review process with just one patch is fine by me. Can you please post it to Phabricator? http://reviews.llvm.org/ Thanks, Greg On Thu, Jul 31, 2014 at 6:51 PM, Daniel Stewart <stewartd at codeaurora.org> wrote:> I’ve been implementing ELF/AArch64 support for lld. I can now successfully > link and run a simple “Hello World” app for both dynamic and static linking. > I’d like to upstream this implementation, but wanted to get feedback on how > people might like to see it. Would people rather see the whole thing in one > shot, each file individually or somehow break it down even farther? The > implementation obviously requires all the files due to their interplay, so > I’m not sure how only some files could be committed without the others. > > > > I don’t yet have tests for everything; is it possible to upstream now or > wait until I have a complete test suite in place as well? > > > > Trying to get feedback now to make the process as smooth as possible. > > > > Thanks, > > Daniel > > > > -- > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation > > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >
Yes, please! Copy me to the reviews, too. --renato On 1 August 2014 08:07, Greg Fitzgerald <garious at gmail.com> wrote:> Cool! Starting the review process with just one patch is fine by me. > Can you please post it to Phabricator? > > http://reviews.llvm.org/ > > Thanks, > Greg > > On Thu, Jul 31, 2014 at 6:51 PM, Daniel Stewart <stewartd at codeaurora.org> wrote: >> I’ve been implementing ELF/AArch64 support for lld. I can now successfully >> link and run a simple “Hello World” app for both dynamic and static linking. >> I’d like to upstream this implementation, but wanted to get feedback on how >> people might like to see it. Would people rather see the whole thing in one >> shot, each file individually or somehow break it down even farther? The >> implementation obviously requires all the files due to their interplay, so >> I’m not sure how only some files could be committed without the others. >> >> >> >> I don’t yet have tests for everything; is it possible to upstream now or >> wait until I have a complete test suite in place as well? >> >> >> >> Trying to get feedback now to make the process as smooth as possible. >> >> >> >> Thanks, >> >> Daniel >> >> >> >> -- >> >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by >> The Linux Foundation >> >> >> >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Daniel, I suggest uploading your complete patch to Phabricator (see: http://reviews.llvm.org/). Chad> I've been implementing ELF/AArch64 support for lld. I can now successfully > link and run a simple "Hello World" app for both dynamic and static > linking. > I'd like to upstream this implementation, but wanted to get feedback on > how > people might like to see it. Would people rather see the whole thing in > one > shot, each file individually or somehow break it down even farther? The > implementation obviously requires all the files due to their interplay, so > I'm not sure how only some files could be committed without the others. > > > > I don't yet have tests for everything; is it possible to upstream now or > wait until I have a complete test suite in place as well? > > > > Trying to get feedback now to make the process as smooth as possible. > > > > Thanks, > > Daniel > > > > -- > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted > by > The Linux Foundation > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >
Hi Daniel, We would need a testcase before you commit the change to the repository. This is to make sure future patches dont break functionality already addressed. Shankar Easwaran On 7/31/2014 8:51 PM, Daniel Stewart wrote:> I've been implementing ELF/AArch64 support for lld. I can now successfully > link and run a simple "Hello World" app for both dynamic and static linking. > I'd like to upstream this implementation, but wanted to get feedback on how > people might like to see it. Would people rather see the whole thing in one > shot, each file individually or somehow break it down even farther? The > implementation obviously requires all the files due to their interplay, so > I'm not sure how only some files could be committed without the others. > > > > I don't yet have tests for everything; is it possible to upstream now or > wait until I have a complete test suite in place as well? > > > > Trying to get feedback now to make the process as smooth as possible. > > > > Thanks, > > Daniel > > > > -- > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation > > > > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140801/bc12795b/attachment.html>
Shankar,
I'll try to add test cases before it gets committed. But
I'll start the process to get it up on Phabricator to at least allow people
to give feedback. Since I fully believe there will be comments I have to
address anyway, I'll be able to add test cases at the same time.
Daniel
From: Shankar Easwaran [mailto:shankare at codeaurora.org]
Sent: Friday, August 01, 2014 1:40 PM
To: Daniel Stewart; llvmdev at cs.uiuc.edu
Subject: Re: [LLVMdev] [lld] ELF/AArch64 support in lld
Hi Daniel,
We would need a testcase before you commit the change to the repository.
This is to make sure future patches dont break functionality already
addressed.
Shankar Easwaran
On 7/31/2014 8:51 PM, Daniel Stewart wrote:
I've been implementing ELF/AArch64 support for lld. I can now successfully
link and run a simple "Hello World" app for both dynamic and static
linking.
I'd like to upstream this implementation, but wanted to get feedback on how
people might like to see it. Would people rather see the whole thing in one
shot, each file individually or somehow break it down even farther? The
implementation obviously requires all the files due to their interplay, so
I'm not sure how only some files could be committed without the others.
I don't yet have tests for everything; is it possible to upstream now or
wait until I have a complete test suite in place as well?
Trying to get feedback now to make the process as smooth as possible.
Thanks,
Daniel
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu>
http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
the Linux Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140801/d569e45e/attachment.html>
Apparently Analagous Threads
- [LLVMdev] [lld] question on ELF section formating
- [LLVMdev] Error with Gold Linker during LTO
- [LLVMdev] [lld] Modeling ELF FileNodes/ControlNodes (Group's) in lld
- [LLVMdev] [lld] Modeling ELF FileNodes/ControlNodes (Group's) in lld
- [LLVMdev] [lld] Modeling ELF FileNodes/ControlNodes (Group's) in lld