It's marked virtual but doesn't override anything, has no overrides, and no in tree callers. Can it be removed? -- ~Craig -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140429/a9e11b8f/attachment.html>
Rafael Espíndola
2014-Apr-30 14:03 UTC
[LLVMdev] What is AMDGPUSubtarget::getDefaultSize for?
On 30 April 2014 00:53, Craig Topper <craig.topper at gmail.com> wrote:> It's marked virtual but doesn't override anything, has no overrides, and no > in tree callers. Can it be removed?In general, it is always OK to delete dead code. If it had an intended use, it is easy to bring it back from svn and properly enable and test it. Cheers, Rafale
On Tue, Apr 29, 2014 at 09:53:18PM -0700, Craig Topper wrote:> It's marked virtual but doesn't override anything, has no overrides, and no > in tree callers. Can it be removed? >I removed this function in r207654. -Tom> -- > ~Craig> _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev