llvm dev - Apr 2014 - [LLVMdev] What is HexagonTargetMachine::addPassesForOptimizations for?

This function is marked virtual but doesn't override anything, doesn't
have
any overrides, and has no in tree callers. Can it be removed?

-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140429/fd552b41/attachment.html>

On 30 April 2014 00:52, Craig Topper <craig.topper at gmail.com>
wrote:
> This function is marked virtual but doesn't override anything,
doesn't have
> any overrides, and has no in tree callers. Can it be removed?
Given that it is dead, yes :-)

Cheers,
Rafael

On 4/30/2014 8:45 AM, Rafael Espíndola wrote:
> On 30 April 2014 00:52, Craig Topper <craig.topper at gmail.com>
wrote:
>> This function is marked virtual but doesn't override anything,
doesn't have
>> any overrides, and has no in tree callers. Can it be removed?
>
> Given that it is dead, yes :-)
>
It used to be called from clang, from lib/CodeGen/BackendUtils.cpp, 
function CreatePasses.  It doesn't seem to be the case anymore.  I'm not
familiar with that part of the code.
+Matthew

-Krzysztof

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation