llvm dev - Oct 2013 - [LLVMdev] [lld][failing test] the reason of ifunc.test failing

Hi,

It looks like the the ELFPassFile doesnot get an ordinal value assigned, 
as its added in a pass.

Is there a way to assign a file ordinal for the files added by Passes ?

Till that time, I am going to XFAIL the ifunc test.

More tests should fail, and am not sure why they are not failing.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the
Linux Foundation

In addition I think the LayoutPass std::stable_sort be replaced with 
std::sort as total ordering is guaranteed as each File would get an 
ordinal and each atom would get an ordinal too, after the below problem 
is fixed.

Thanks

Shankar Easwaran

On 10/6/2013 10:54 PM, Shankar Easwaran wrote:
> Hi,
>
> It looks like the the ELFPassFile doesnot get an ordinal value 
> assigned, as its added in a pass.
>
> Is there a way to assign a file ordinal for the files added by Passes ?
>
> Till that time, I am going to XFAIL the ifunc test.
>
> More tests should fail, and am not sure why they are not failing.
>
> Thanks
>
> Shankar Easwaran
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the
Linux Foundation

Ping ?

Do you think that we need to have an API in LinkingContext to return the 
next ordinal available, so that files created by passes can be assigned 
ordinals ?

Thanks

Shankar Easwaran

On 10/6/2013 11:07 PM, Shankar Easwaran wrote:
> In addition I think the LayoutPass std::stable_sort be replaced with 
> std::sort as total ordering is guaranteed as each File would get an 
> ordinal and each atom would get an ordinal too, after the below 
> problem is fixed.
>
> Thanks
>
> Shankar Easwaran
>
> On 10/6/2013 10:54 PM, Shankar Easwaran wrote:
>> Hi,
>>
>> It looks like the the ELFPassFile doesnot get an ordinal value 
>> assigned, as its added in a pass.
>>
>> Is there a way to assign a file ordinal for the files added by Passes ?
>>
>> Till that time, I am going to XFAIL the ifunc test.
>>
>> More tests should fail, and am not sure why they are not failing.
>>
>> Thanks
>>
>> Shankar Easwaran
>>
>
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the
Linux Foundation