Hi, I am writing tool to simplify automated refactorings. One of prerequisites is have clean codebase, so a refactorer can be simple and created formatting inconsistencies can be eliminated by formatter. My plan to keep codebase clean is first run a cleanup systemwide, then keep it by hook/ periodicaly rerunning cleanup. I put it for now here. https://github.com/neleai/stylepp I ran a scripts that remove trailing whitespaces and fix leading spaces followed by tabs, commands are: script/stylepp_skeleton stylepp_trailing_space and script/stylepp_skeleton stylepp_space_after_tab on llvm codebase, rather large patches are here (Is this correct list or should I split them somewhat?) kam.mff.cuni.cz/~ondra/llvm_whitespace.patch kam.mff.cuni.cz/~ondra/clang_whitespace.patch kam.mff.cuni.cz/~ondra/compiler_rt_whitespace.patch I do not know if there are directories that I should keeps so could you tell me a list of them? Please use flags to ignore whitespaces like hg annotate -w git blame -w patch -l git apply --ignore-space Could you also verify each patch by git diff -w that it indeed touches only whitespaces?
On Jul 8, 2013, at 11:39 AM, Ondřej Bílka <neleai at seznam.cz> wrote:> Hi, > > I am writing tool to simplify automated refactorings. One of > prerequisites is have clean codebase, so a refactorer can be simple and > created formatting inconsistencies can be eliminated by formatter.Cool.> My plan to keep codebase clean is first run a cleanup systemwide, then > keep it by hook/ periodicaly rerunning cleanup.Please don't do this. We don't like widespread changes like this, they make svn archeology more difficult. -Chris
On Mon, Jul 08, 2013 at 04:14:40PM -0700, Chris Lattner wrote:> > On Jul 8, 2013, at 11:39 AM, Ondřej Bílka <neleai at seznam.cz> wrote: > > > Hi, > > > > I am writing tool to simplify automated refactorings. One of > > prerequisites is have clean codebase, so a refactorer can be simple and > > created formatting inconsistencies can be eliminated by formatter. > > Cool. > > > My plan to keep codebase clean is first run a cleanup systemwide, then > > keep it by hook/ periodicaly rerunning cleanup. > > Please don't do this. We don't like widespread changes like this, they make svn archeology more difficult. >Please use git. It has many features that svn lacks git blame -w is one of those. Also this change is not because these spaces are inconsistent but because they cause problems. When you do a diff with some spaces followed by tabs then formatting can get weird because tab shifted. Also with trailing spaces and long line it will wrap to new line which will look empty. But as I looked most of lines that I changed are empty anyway so we do not lose much of history.