llvm dev - Jan 2013 - [LLVMdev] [PATCH] Coding standards: don't use ``inline`` when defining a function in a class definition

Hello,

This came up on IRC in context of r173842, and it was suggested to
codify this unspoken rule.

Current practice is not to use 'inline' in:

  class Foo {
  public:
    inline void bar() {
      // ...
    }
  };

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at
gmail.com>*/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coding-standards-inline-v1.patch
Type: application/octet-stream
Size: 843 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130130/46ba8f64/attachment.obj>

On Wed, Jan 30, 2013 at 1:08 AM, Dmitri Gribenko <gribozavr at gmail.com>
wrote:
> Hello,
>
> This came up on IRC in context of r173842, and it was suggested to
> codify this unspoken rule.
>
> Current practice is not to use 'inline' in:
>
>   class Foo {
>   public:
>     inline void bar() {
>       // ...
>     }
>   };
Ping.

This patch is not changing anything, it just documents the rule we
already follow.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at
gmail.com>*/

On Mon, Feb 4, 2013 at 1:31 AM, Dmitri Gribenko <gribozavr at gmail.com>
wrote:
> On Wed, Jan 30, 2013 at 1:08 AM, Dmitri Gribenko <gribozavr at
gmail.com>
> wrote:
> > Hello,
> >
> > This came up on IRC in context of r173842, and it was suggested to
> > codify this unspoken rule.
> >
> > Current practice is not to use 'inline' in:
> >
> >   class Foo {
> >   public:
> >     inline void bar() {
> >       // ...
> >     }
> >   };
>
> Ping.
>
> This patch is not changing anything, it just documents the rule we
> already follow.

Sure. LGTM.

Note that I don't have any real opinion about this other than that it's
one
less needless keyword. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130204/92efa108/attachment.html>