Zhanyong Wan (λx.x x)
2011-Feb-11 20:55 UTC
[LLVMdev] adding a function to test whether a char is a path separator
Hi Doug, While refactoring clang::FileManager to use llvm::sys::path, I had a need for a function to test whether a char is a path separator. I think it would be generally useful. Would you be able to review it? You can see http://codereview.appspot.com/4186045 or the attachment. Thanks, -- Zhanyong -------------- next part -------------- A non-text attachment was scrubbed... Name: is_separator.patch Type: text/x-patch Size: 2482 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110211/54ad4b7d/attachment.bin>
Douglas Gregor
2011-Feb-11 21:01 UTC
[LLVMdev] adding a function to test whether a char is a path separator
Looks good to me! - Doug On Feb 11, 2011, at 12:55 PM, Zhanyong Wan (λx.x x) wrote:> Hi Doug, > > While refactoring clang::FileManager to use llvm::sys::path, I had a > need for a function to test whether a char is a path separator. I > think it would be generally useful. Would you be able to review it? > You can see http://codereview.appspot.com/4186045 or the attachment. > > Thanks, > -- > Zhanyong > <is_separator.patch>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110211/f593ffd9/attachment.html>
Possibly Parallel Threads
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] draft rule for naming types/functions/variables