Sandeep Patel
2010-Sep-27 18:50 UTC
[LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
On Mon, Sep 27, 2010 at 5:02 PM, Evzen Muller <evzen.muller at arm.com> wrote:> > To make it easier to review & commit I have split and cleaned-up our > original > "Support for ARM Run-Time ABI" patch, this part adds support for calls which > > can be mapped using setLibcallName.As noted in the earlier thread on this, I'm pretty sure that we need to only apply the AAPCS calling convention to exactly the set of libcalls that you're adding here. Other libcalls outside this set should use the "native" calling convention such as AAPCS-VFP. deep
Evzen Muller
2010-Sep-28 09:11 UTC
[LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
Hi Deep, Loop for setting all libcall calling conventions to ARM_AAPCS was in original version, but I agree that it could have unexpected side effects. Attached patch sets calling convention only for added libcalls. Evzen> -----Original Message----- > From: Sandeep Patel [mailto:deeppatel1987 at gmail.com] > Sent: 27 September 2010 19:50 > To: Evzen Muller > Cc: llvmdev at cs.uiuc.edu > Subject: Re: [LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and > Integer helper functions) > > On Mon, Sep 27, 2010 at 5:02 PM, Evzen Muller <evzen.muller at arm.com> > wrote: > > > > To make it easier to review & commit I have split and cleaned-up our > > original > > "Support for ARM Run-Time ABI" patch, this part adds support for calls > which > > > > can be mapped using setLibcallName. > > As noted in the earlier thread on this, I'm pretty sure that we need > to only apply the AAPCS calling convention to exactly the set of > libcalls that you're adding here. Other libcalls outside this set > should use the "native" calling convention such as AAPCS-VFP. > > deep-------------- next part -------------- A non-text attachment was scrubbed... Name: arm-rtabi.patch Type: application/octet-stream Size: 9776 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100928/378cc260/attachment.obj>
Apparently Analagous Threads
- [LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
- [LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
- Bug 20871 -- is there a fix or work around?
- [LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
- [LLVMdev] libcalls for shifts