llvm dev - Aug 2008 - [LLVMdev] thread class patch to llvm/system

Hi!
Here i a patch for support platform independent threading. (needed for clang
server (clang distcc project)).

Cheers,
Csaba Hruska
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080810/47f6f0c1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thread.patch
Type: text/x-diff
Size: 10506 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080810/47f6f0c1/attachment.patch>

Hi Csaba,

+      /// Releases and removes the lock
+      /// @brief Destructor
+      ~Thread ( void );

What lock is that?  Also, why ( void ) and not ()?  (Lots more
of these later).

+      typedef void (*ThreadFunc)( void *data );
+
+      /// Starts the thread with the given main function and parameter.
+      /// @brief Starts the thread.
+      void start( ThreadFunc f, void *data );

Wouldn't it be more C++ like to have start be an abstract method of
Thread.  Rather than passing a function pointer with data like now,
you would derive a subclass of Thread with the data as a field and
with start defined to do whatever the operation is.  Or something
like that.

I didn't have time to read the other files, sorry.

Ciao,

Duncan.