llvm dev - Jul 2004 - [LLVMdev] Size/Alignment handling bug?

I think there's possible bug in alignment handling. When getTypeInfo
function
in TargetData.cpp is called on:

   [100 x short]

it always returns 200 as the size. However, if alignment for short is
'4',
then each array element should be aligned at 4-byte boundary, and the total 
size of the array is more like 400.

For a while, I've made the attached local modification. Does it makes sense?

- Volodya

P.S. It's a lot of fun writing codegen for a target which has no support for
addressing/working with individual bytes ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TargetData.diff
Type: text/x-diff
Size: 659 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20040701/ab236778/attachment.diff>

On Thu, 1 Jul 2004, Vladimir Prus wrote:
> I think there's possible bug in alignment handling. When getTypeInfo
function
> in TargetData.cpp is called on:
>
>    [100 x short]
>
> it always returns 200 as the size. However, if alignment for short is
'4',
> then each array element should be aligned at 4-byte boundary, and the total
> size of the array is more like 400.
>
> For a while, I've made the attached local modification. Does it makes
> sense?
Sounds good.  Applied:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040628/015613.html
> P.S. It's a lot of fun writing codegen for a target which has no
support
> for addressing/working with individual bytes ;-)
Yeah, no kidding!  Thanks for the bug fixes in this area! :)

-Chris

-- 
http://llvm.cs.uiuc.edu/
http://www.nondot.org/~sabre/Projects/