netfilter buglog - May 2016 - [Bug 1067] New: Compilation failure on Linux 4.5.x when including libiptc/libiptc.h

https://bugzilla.netfilter.org/show_bug.cgi?id=1067

            Bug ID: 1067
           Summary: Compilation failure on Linux 4.5.x when including
                    libiptc/libiptc.h
           Product: iptables
           Version: 1.4.x
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: iptables
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: quentin at armitage.org.uk

Including <libiptc/libiptc.h> causes a compilation failure with multiple
messages like:

In file included from /usr/include/linux/netfilter_ipv4/ip_tables.h:20:0,
                 from /usr/include/libiptc/libiptc.h:12,
                 from /tmp/inc.c:1:
/usr/include/linux/if.h:71:2: error: redeclaration of enumerator ?IFF_UP?
In file included from /usr/include/libiptc/ipt_kernel_headers.h:14:0,
                 from /usr/include/libiptc/libiptc.h:6,
                 from /tmp/inc.c:1:
/usr/include/net/if.h:44:5: note: previous definition of ?IFF_UP? was here

Kernel patch 1ffad83dffd675cd742286ae82dca7d746cb0da8 appears to have caused
the problem, by including <linux/if.h>, which has multiple namespace
collisions
with <net/if.h>.

<libiptc/libiptc.h> includes <libiptc/ipt_kernel_headers.h> and also
<linux/netfilter_ipv4/ip_tables.h>.

<libiptc/ipt_kernel_headers.h> includes <net/if.h>, and since the
above kernel
patch, <linux/netfilter_ipv4/ip_tables.h> includes <linux.if.h>.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160514/ddfb5601/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1067

Quentin Armitage <quentin at armitage.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P1
           Severity|enhancement                 |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160514/aca882a0/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1067

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pablo at netfilter.org

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Fixed and enqueue for -stable. See:

http://patchwork.ozlabs.org/patch/614151/

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160516/3847e4aa/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1067

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20160630/e697a06e/attachment.html>