Syslinux - May 2014 - [PATCH 2/2] core/fs: Add support for Unix File system 1/2.

On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote:
> +static int ufs_readlink(struct inode *inode, char *buf)
> +{
> +    ufs_debug("ufs_readlink\n");
> +    return inode->size;
> +}
Something missing here?

	-hpa

On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com>
wrote:
> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote:
>> +static int ufs_readlink(struct inode *inode, char *buf)
>> +{
>> +    ufs_debug("ufs_readlink\n");
>> +    return inode->size;
>> +}
>
> Something missing here?
Yes, implementation. It's just a placeholder until I implement it. You
can see that I didn't even set it into fs_ops. At that time, I think
Matt removed it himself as compiler complained about it being
unused.
>
>         -hpa
>
>


-- 
Raphael S. Carvalho

On 05/29/2014 07:36 AM, Raphael S Carvalho wrote:
> On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com>
wrote:
>> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote:
>>> +static int ufs_readlink(struct inode *inode, char *buf)
>>> +{
>>> +    ufs_debug("ufs_readlink\n");
>>> +    return inode->size;
>>> +}
>>
>> Something missing here?
> Yes, implementation. It's just a placeholder until I implement it. You
> can see that I didn't even set it into fs_ops. At that time, I think
> Matt removed it himself as compiler complained about it being unused.
>>
Yes, it did.  However, it would be better to implement it.  As far as I
know, UFS symlinks are very similar to ext* symlinks (not surprising
since ext2 was heavily inspired by UFS): symlinks below a specific size
is stored in the inode overlaying the block pointers, and otherwise the
symlink is just an ordinary file.

	-hpa