search for: ufs_readlink

On 05/29/2014 07:36 AM, Raphael S Carvalho wrote: > On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: >> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >>> +static int ufs_readlink(struct inode *inode, char *buf) >>> +{ >>> + ufs_debug("ufs_readlink\n"); >>> + return inode->size; >>> +} >> >> Something missing here? > Yes, implementation. It's just a placeholder until I implement it. You > can see th...

On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: > +static int ufs_readlink(struct inode *inode, char *buf) > +{ > + ufs_debug("ufs_readlink\n"); > + return inode->size; > +} Something missing here? -hpa

...H. Peter Anvin <hpa at zytor.com> wrote: >> On 05/29/2014 07:36 AM, Raphael S Carvalho wrote: >>> On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: >>>> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >>>>> +static int ufs_readlink(struct inode *inode, char *buf) >>>>> +{ >>>>> + ufs_debug("ufs_readlink\n"); >>>>> + return inode->size; >>>>> +} >>>> >>>> Something missing here? >>> Yes, implementation. It's just...

...14 at 11:40 AM, H. Peter Anvin <hpa at zytor.com> wrote: > On 05/29/2014 07:36 AM, Raphael S Carvalho wrote: >> On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: >>> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >>>> +static int ufs_readlink(struct inode *inode, char *buf) >>>> +{ >>>> + ufs_debug("ufs_readlink\n"); >>>> + return inode->size; >>>> +} >>> >>> Something missing here? >> Yes, implementation. It's just a placeholder until I imple...

...symlink is just an ordinary file. > I initially thought that readlink was intended for hard link, don't we > support them? But then it occurred to me that readlink is, of course, > intended for symlinks. > Don't you think the series could be merged as it-is? I will work on > ufs_readlink at this weekend, and as you mentioned, it shouldn't take > that long as ext2 could be used as a reference. I would love to see > the series merged as it has been around for months :-) I don't want to merge an under-development feature this late in the release cycle. In fact, if some...

On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: > On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >> +static int ufs_readlink(struct inode *inode, char *buf) >> +{ >> + ufs_debug("ufs_readlink\n"); >> + return inode->size; >> +} > > Something missing here? Yes, implementation. It's just a placeholder until I implement it. You can see that I didn't even set it into f...

...14 at 11:40 AM, H. Peter Anvin <hpa at zytor.com> wrote: > On 05/29/2014 07:36 AM, Raphael S Carvalho wrote: >> On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: >>> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >>>> +static int ufs_readlink(struct inode *inode, char *buf) >>>> +{ >>>> + ufs_debug("ufs_readlink\n"); >>>> + return inode->size; >>>> +} >>> >>> Something missing here? >> Yes, implementation. It's just a placeholder until I imple...

...lt;hpa at zytor.com> wrote: >>> On 05/29/2014 07:36 AM, Raphael S Carvalho wrote: >>>> On Thu, May 29, 2014 at 11:30 AM, H. Peter Anvin <hpa at zytor.com> wrote: >>>>> On 05/29/2014 07:20 AM, Raphael S.Carvalho wrote: >>>>>> +static int ufs_readlink(struct inode *inode, char *buf) >>>>>> +{ >>>>>> + ufs_debug("ufs_readlink\n"); >>>>>> + return inode->size; >>>>>> +} >>>>> >>>>> Something missing here? >>>> Yes, i...

It's needed to enumerate both UFS1/2 since they have different magic numbers and super block offsets. Besides, UFS2 can be installed in the 0-64k range like BTRFS, whereas UFS1 can't. UFS2 has no cow feature unlike BTRFS. Signed-off-by: Raphael S.Carvalho <raphael.scarv at gmail.com> --- extlinux/main.c | 79 ++++++++++--- extlinux/ufs.h | 26 ++++

From: Raphael S. Carvalho <raphael.scarv at gmail.com> Wrote the documentation below. I think it would be good to push the doc to the wiki as soon as the UFS support gets merged. Unix Fast File System (UFS/FFS) 1/2 on Syslinux - (usage/install) ----- There is a confusion about the name of this file system, then I decided to contact the author who replied: "The name has always been

...+ufs_iget(const char *dname, struct inode *parent) +{ + const struct ufs_dir_entry *dir; + struct fs_info *fs = parent->fs; + + dir = ufs_find_entry(fs, parent, dname); + if (!dir) + return NULL; + + return UFS_SB(fs)->ufs_iget_by_inr(fs, dir->inode_value); +} + +static int ufs_readlink(struct inode *inode, char *buf) +{ + ufs_debug("ufs_readlink\n"); + return inode->size; +} + +static inline enum dir_type_flags get_inode_mode(uint8_t attr) +{ + return (attr & UFS_DTYPE_DIR) ? DT_DIR : DT_REG; +} + +/* + * Read one directory entry at a time + */ +static i...

...+ufs_iget(const char *dname, struct inode *parent) +{ + const struct ufs_dir_entry *dir; + struct fs_info *fs = parent->fs; + + dir = ufs_find_entry(fs, parent, dname); + if (!dir) + return NULL; + + return UFS_SB(fs)->ufs_iget_by_inr(fs, dir->inode_value); +} + +static int ufs_readlink(struct inode *inode, char *buf) +{ + ufs_debug("ufs_readlink\n"); + return inode->size; +} + +static inline enum dir_type_flags get_inode_mode(uint8_t attr) +{ + return (attr & UFS_DTYPE_DIR) ? DT_DIR : DT_REG; +} + +/* + * Read one directory entry at a time + */ +static i...

From: Raphael S. Carvalho <raphael.scarv at gmail.com> Change since v1: * Fix bug on dentry structure (thank you specification; btw, sarcasm), and consequently a bug on ufs_readdir. * Add readlink support (applied tests for symlinks whose destionation path were stored in blk pointers and the file itself). * Several improvements. Wrote the documentation below. I think it would be good to