陳韋任 via llvm-dev
2017-Apr-27 14:13 UTC
[llvm-dev] Is it a good idea to mark class as deprecated?
Hi All, During a discussion about instruction scheduling in LLVM [1], I realize that class PostRASchedulerList actually is deprecated. The documentation of instruction scheduling is pretty poor, so I cannot find such information. Removing the obsoleted class might be too aggressive. I am wondering if we can mark the class as deprecated [2] (seems C++14 feature required), or at least making a note on [3]. Thoughts? :-) [1] http://lists.llvm.org/pipermail/llvm-dev/2017-April/112358.html [2] http://josephmansfield.uk/articles/marking-deprecated-c++14.html [3] http://llvm.org/docs/CodeGenerator.html#selectiondag-scheduling-and-formation-phase -- Wei-Ren Chen (陳韋任) Homepage: https://people.cs.nctu.edu.tw/~chenwj
Michael Spencer via llvm-dev
2017-May-04 23:46 UTC
[llvm-dev] Is it a good idea to mark class as deprecated?
On Thu, Apr 27, 2017 at 7:13 AM, 陳韋任 via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Hi All, > > During a discussion about instruction scheduling in LLVM [1], I > realize that class PostRASchedulerList > actually is deprecated. The documentation of instruction scheduling is > pretty poor, so I cannot find such > information. Removing the obsoleted class might be too aggressive. I > am wondering if we can mark > the class as deprecated [2] (seems C++14 feature required), or at > least making a note on [3]. > > Thoughts? :-) > > [1] http://lists.llvm.org/pipermail/llvm-dev/2017-April/112358.html > [2] http://josephmansfield.uk/articles/marking-deprecated-c++14.html > [3] http://llvm.org/docs/CodeGenerator.html#selectiondag-scheduling-and- > formation-phase > > -- > Wei-Ren Chen (陳韋任) > Homepage: https://people.cs.nctu.edu.tw/~chenwj > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >Not sure about that class specifically, but we have LLVM_ATTRIBUTE_DEPRECATED in Support/Compiler.h. However I'm not sure it will work for class types. - Michael Spencer -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170504/8c50b561/attachment.html>
陳韋任 via llvm-dev
2017-May-05 12:27 UTC
[llvm-dev] Is it a good idea to mark class as deprecated?
> > > Not sure about that class specifically, but we have > LLVM_ATTRIBUTE_DEPRECATED in Support/Compiler.h. However I'm not sure it > will work for class types. >A quick `grep -r "LLVM_ATTRIBUTE_DEPRECATED"` shows no one use it. Well, at least a web page (doxygen maybe?) saying the class is deprecated would be helpful. Regards, chenwj -- Wei-Ren Chen (陳韋任) Homepage: https://people.cs.nctu.edu.tw/~chenwj -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170505/3f40bc01/attachment.html>
Seemingly Similar Threads
- Is subclass of ScheduleDAGMILive a pre-RA scheduler?
- [Newbie Question] Compute a schedule region's scheduled cycles.
- [LLVMdev] Activating MIPS Code Emitter.
- Pre-RA scheduler does not generate NOPs when getHazardType() returns NoopHazard
- [LLVMdev] Integrated instruction scheduling/register allocation