Btrfs devel - Apr 2012 - block_rsv_check EAGAIN vs ENOSPC...

With 3.4-rc4 under certain workloads, I see btrfs_block_rsv_check
return -ENOSPC.

Since btrfs_block_rsv_check can only return -ENOSPC or 0,
relocation.c:3816 checks for -EAGAIN, which is either redundant or
should be -ENOSPC, which I initially suspected.

Let me know which the behaviour should be and I''ll get a patch tested
and sent.

Thanks,
  Daniel
-- 
Daniel J Blueman
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, Apr 24, 2012 at 11:50:24PM +0800, Daniel J Blueman
wrote:
> With 3.4-rc4 under certain workloads, I see btrfs_block_rsv_check
> return -ENOSPC.
> 
> Since btrfs_block_rsv_check can only return -ENOSPC or 0,
> relocation.c:3816 checks for -EAGAIN, which is either redundant or
> should be -ENOSPC, which I initially suspected.
> 
> Let me know which the behaviour should be and I''ll get a patch
tested and sent.
> 
Yup you are right, thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html