I can''t pass 254, and below is the output: 254 3s ... - output mismatch (see 254.out.bad) ... ID 256 top level 5 path snap -ID 257 top level 5 path subvol +ID 258 top level 5 path subvol When space cache is enabled (and now mkfs.btrfs always enables it), there will be some space cache inodes in the root tree, and they consume some IDs, and that''s why "subvol" has the ID 258 but not 257. Just disable space cache for this test case. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- 254 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/254 b/254 index 5216120..1cd4832 100755 --- a/254 +++ b/254 @@ -48,7 +48,7 @@ _supported_os Linux _require_scratch _scratch_mkfs > /dev/null 2>&1 -_scratch_mount +_scratch_mount -o nospace_cache # First test basic snapshotting echo "Creating file foo in root dir" -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
(2011/11/18 17:43), Li Zefan wrote:> I can''t pass 254, and below is the output: > > 254 3s ... - output mismatch (see 254.out.bad) > ... > ID 256 top level 5 path snap > -ID 257 top level 5 path subvol > +ID 258 top level 5 path subvol > > When space cache is enabled (and now mkfs.btrfs always enables it), > there will be some space cache inodes in the root tree, and they > consume some IDs, and that''s why "subvol" has the ID 258 but not 257. > > Just disable space cache for this test case. > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > --- > 254 | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/254 b/254 > index 5216120..1cd4832 100755 > --- a/254 > +++ b/254 > @@ -48,7 +48,7 @@ _supported_os Linux > _require_scratch > > _scratch_mkfs > /dev/null 2>&1 > -_scratch_mount > +_scratch_mount -o nospace_cache > > # First test basic snapshotting > echo "Creating file foo in root dir"I got following error on fedora 16 with your patch: @@ -1,40 +1,36 @@ QA output created by 254 +mount: wrong fs type, bad option, bad superblock on /dev/sdc2, + missing codepage or helper program, or other error + In some cases useful info is found in syslog - try + dmesg | tail or so + Creating file foo in root dir List root dir foo Creating snapshot of root dir -Create a snapshot of ''SCRATCH_MNT'' in ''SCRATCH_MNT/snap'' +ERROR: ''/mnt2'' is not a subvolume List root dir after snapshot foo -snap List snapshot dir -foo +ls: cannot access /mnt2/snap: No such file or directory : : And in dmesg: [246554.739092] btrfs: unrecognized mount option ''nospace_cache'' Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hidetoshi Seto wrote:> (2011/11/18 17:43), Li Zefan wrote: >> I can''t pass 254, and below is the output: >> >> 254 3s ... - output mismatch (see 254.out.bad) >> ... >> ID 256 top level 5 path snap >> -ID 257 top level 5 path subvol >> +ID 258 top level 5 path subvol >> >> When space cache is enabled (and now mkfs.btrfs always enables it), >> there will be some space cache inodes in the root tree, and they >> consume some IDs, and that''s why "subvol" has the ID 258 but not 257. >> >> Just disable space cache for this test case. >> >> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> >> --- >> 254 | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/254 b/254 >> index 5216120..1cd4832 100755 >> --- a/254 >> +++ b/254 >> @@ -48,7 +48,7 @@ _supported_os Linux >> _require_scratch >> >> _scratch_mkfs > /dev/null 2>&1 >> -_scratch_mount >> +_scratch_mount -o nospace_cache >> >> # First test basic snapshotting >> echo "Creating file foo in root dir" > > I got following error on fedora 16 with your patch: >This is an alternative fix: ======================= [PATCH] 254: avoid output mismatch due to space cache I can''t pass 254, and below is the output: 254 3s ... - output mismatch (see 254.out.bad) ... ID 256 top level 5 path snap -ID 257 top level 5 path subvol +ID 258 top level 5 path subvol When space cache is enabled (and now mkfs.btrfs always enables it), there will be some space cache inodes in the root tree, and they consume some IDs, and that''s why "subvol" has the ID 258 but not 257. Just list subvolume names, don''t assume what ID numbers those subvolumes will have. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- 254 | 2 +- 254.out | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/254 b/254 index 5216120..7b74a02 100755 --- a/254 +++ b/254 @@ -95,7 +95,7 @@ ls $SCRATCH_MNT # Test listing the subvolumes echo "Listing subvolumes" -btrfs subvolume list $SCRATCH_MNT | _filter_scratch +btrfs subvolume list $SCRATCH_MNT | awk ''{ print $NF }'' # Delete the snapshot btrfs subvolume delete $SCRATCH_MNT/snap | _filter_scratch diff --git a/254.out b/254.out index 582357a..d4b5346 100644 --- a/254.out +++ b/254.out @@ -31,8 +31,8 @@ List root dir snap subvol Listing subvolumes -ID 256 top level 5 path snap -ID 257 top level 5 path subvol +snap +subvol Delete subvolume ''SCRATCH_MNT/snap'' List root dir subvol -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 21, 2011 at 10:42:04AM +0800, Li Zefan wrote:> This is an alternative fix:I have already applied your previous one. Can you rediff it ontop of the current xfstests-dev tree? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html