Josef Bacik
2010-Nov-19 14:33 UTC
[PATCH] Btrfs: do not loop through raid types when looking for free extent V2
There is a bug in find_free_extent where if we don''t find a free extent
in the
raid type we are looking for, we loop through to the next raid type. This is
not ok since we need to make sure we honor the raid types we are given. So
instead kill this check and get the proper index for the raid type we want from
the allocator. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
---
V1->V2:
-I missed a spot where we set index=0 in find_free_extent
fs/btrfs/extent-tree.c | 21 ++++++++-------------
1 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 0c097f3..132276a 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4785,16 +4785,16 @@ wait_block_group_cache_done(struct
btrfs_block_group_cache *cache)
return 0;
}
-static int get_block_group_index(struct btrfs_block_group_cache *cache)
+static int get_block_group_index(u64 flags)
{
int index;
- if (cache->flags & BTRFS_BLOCK_GROUP_RAID10)
+ if (flags & BTRFS_BLOCK_GROUP_RAID10)
index = 0;
- else if (cache->flags & BTRFS_BLOCK_GROUP_RAID1)
+ else if (flags & BTRFS_BLOCK_GROUP_RAID1)
index = 1;
- else if (cache->flags & BTRFS_BLOCK_GROUP_DUP)
+ else if (flags & BTRFS_BLOCK_GROUP_DUP)
index = 2;
- else if (cache->flags & BTRFS_BLOCK_GROUP_RAID0)
+ else if (flags & BTRFS_BLOCK_GROUP_RAID0)
index = 3;
else
index = 4;
@@ -4834,7 +4834,7 @@ static noinline int find_free_extent(struct
btrfs_trans_handle *trans,
struct btrfs_space_info *space_info;
int last_ptr_loop = 0;
int loop = 0;
- int index = 0;
+ int index = get_block_group_index(data);
bool found_uncached_bg = false;
bool failed_cluster_refill = false;
bool failed_alloc = false;
@@ -4913,7 +4913,6 @@ ideal_cache:
btrfs_put_block_group(block_group);
up_read(&space_info->groups_sem);
} else {
- index = get_block_group_index(block_group);
goto have_block_group;
}
} else if (block_group) {
@@ -5145,14 +5144,11 @@ checks:
loop:
failed_cluster_refill = false;
failed_alloc = false;
- BUG_ON(index != get_block_group_index(block_group));
+ BUG_ON(index != get_block_group_index(block_group->flags));
btrfs_put_block_group(block_group);
}
up_read(&space_info->groups_sem);
- if (!ins->objectid && ++index < BTRFS_NR_RAID_TYPES)
- goto search;
-
/* LOOP_FIND_IDEAL, only search caching/cached bg''s, and
don''t wait for
* for them to make caching progress. Also
* determine the best possible bg to cache
@@ -5166,7 +5162,6 @@ loop:
if (!ins->objectid && loop < LOOP_NO_EMPTY_SIZE &&
(found_uncached_bg || empty_size || empty_cluster ||
allowed_chunk_alloc)) {
- index = 0;
if (loop == LOOP_FIND_IDEAL && found_uncached_bg) {
found_uncached_bg = false;
loop++;
@@ -8204,7 +8199,7 @@ int btrfs_free_block_groups(struct btrfs_fs_info *info)
static void __link_block_group(struct btrfs_space_info *space_info,
struct btrfs_block_group_cache *cache)
{
- int index = get_block_group_index(cache);
+ int index = get_block_group_index(cache->flags);
down_write(&space_info->groups_sem);
list_add_tail(&cache->list, &space_info->block_groups[index]);
--
1.6.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html