David Nicol
2010-Oct-06 15:05 UTC
patch intoducing IOctl #21 allowing for waiting for completion of deleted subvol recovery
Written against the btrfs-unstable git tree, the attached patch installs cleanly against the latest kernel (as of two weeks ago.) The patches for btrfsctl and btrfs programs will be coming soon; I''m adding support for ISO8061 duration strings instead of (or in addition to) milliseconds and thinking about switching the order of the two args to btrfsctl -C from (path(default=.), ms(default=0)) to timeout then path, to keep it consistent with the other btrfsctl commands. Currently -C is special-cased in the bottom half of my btrfsctl.c because the path isn''t the last argument. Btrfsctl apparently allows several operations to be presented as one set of command line arguments, sort of like find(1) does; would someone who does that a lot please respond off-list to discuss the ideal semantics of new commands? Also, I can now privately send the progs patch to anyone who wants to test it as-is, but I don''t want to "publish" it until the interface (what format the optional timeout is in) is frozen.
Goffredo Baroncelli
2010-Oct-06 17:59 UTC
Re: patch intoducing IOctl #21 allowing for waiting for completion of deleted subvol recovery
On Wednesday, 06 October, 2010, David Nicol wrote: [..]> > Btrfsctl apparently allows several operations to be presented as one > set of command line arguments, sort of like find(1) does; would > someone who does that a lot please respond off-list to discuss the > ideal semantics of new commands? > > Also, I can now privately send the progs patch to anyone who wants to > test it as-is, but I don''t want to "publish" it until the interface > (what format the optional timeout is in) is frozen.Why you want discuss this privately ? The ideal place where discuss an interface is a mailing list.. Regards G.Baroncelli -- gpg key@ keyserver.linux.it:Goffredo Baroncelli (ghigo) <kreijackATinwind.it> Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jérôme Poulin
2010-Oct-06 18:41 UTC
Re: patch intoducing IOctl #21 allowing for waiting for completion of deleted subvol recovery
Hi, On Wed, Oct 6, 2010 at 11:05 AM, David Nicol <davidnicol@gmail.com> wrote:> The patches for btrfsctl and btrfs programs will be coming soon; I''m > adding support for ISO8061 duration strings instead of (or in addition > to) milliseconds and thinking about switching the order of the two > args to btrfsctl -C from (path(default=.), ms(default=0)) to timeout > then path, to keep it consistent with the other btrfsctl commands. > Currently -C is special-cased in the bottom half of my btrfsctl.c > because the path isn''t the last argument. > > Btrfsctl apparently allows several operations to be presented as one > set of command line arguments, sort of like find(1) does; would > someone who does that a lot please respond off-list to discuss the > ideal semantics of new commands? >The first thing I notice is that you use btrfsctl, you should base this work on the new ''btrfs'' command, which is consistant in how the command are structured. You could use: btrfs filesystem sync -d <path> for example, it would be like a normal sync but waits for pending ''-d''eletion. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html