Looking at http://edgeapi.rubyonrails.org/, I don''t see any docs for AbstractController. Nothing appears for the layout method for example. Am I missing something or does something need to be changed in the docs to get them to appear? Thanks -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Fri, Aug 6, 2010 at 11:19 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> Looking at http://edgeapi.rubyonrails.org/, I don''t see any docs for > AbstractController. Nothing appears for the layout method for > example. Am I missing something or does something need to be changed > in the docs to get them to appear?I''ve added Abstract Controller to the rdoc task, and some of it is already online. But for some reason AC::Layouts is not being generated. I''ll investigate it this weekend. Thanks for the heads up. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Sat, Aug 7, 2010 at 2:38 AM, Xavier Noria <fxn@hashref.com> wrote:> On Fri, Aug 6, 2010 at 11:19 PM, Andrew Kaspick <akaspick@gmail.com> wrote: > >> Looking at http://edgeapi.rubyonrails.org/, I don''t see any docs for >> AbstractController. Nothing appears for the layout method for >> example. Am I missing something or does something need to be changed >> in the docs to get them to appear? > > I''ve added Abstract Controller to the rdoc task, and some of it is > already online. But for some reason AC::Layouts is not being > generated. I''ll investigate it this weekend.Understood! It was fortunate that you were interested in AbstractController::Layouts, investigating this has uncovered that the following files were being excluded by RDoc: railties/lib/rails/generators/erb.rb actionpack/lib/abstract_controller/layouts.rb actionpack/lib/action_controller/caching/fragments.rb actionpack/lib/action_controller/record_identifier.rb actionpack/lib/action_view/base.rb actionpack/lib/action_view/helpers/cache_helper.rb actionpack/lib/action_view/helpers/capture_helper.rb actionpack/lib/action_view/helpers/record_tag_helper.rb actionpack/lib/action_view/helpers/text_helper.rb actionpack/lib/action_view/render/layouts.rb actionpack/lib/action_view/render/partials.rb actionpack/lib/action_view/template/handlers/erb.rb activesupport/lib/active_support/benchmarkable.rb In this set we distinguish two subsets, this one (1) railties/lib/rails/generators/erb.rb actionpack/lib/action_view/template/handlers/erb.rb and the rest (2). Reason for (1) is that RDoc skips files whose name match /erb\.rb$/. Explanation for (2) is that RDoc skips files that have 4 or more occurrences of <%|%> in their first 1024 bytes (????). As a quick hack I''ve redefined RDoc::Parser.binary? in the very Rakefile and regenerated the edge API, should be complete now. (I had to tell Chrome to reload the frames, it''s in the contextual menu.) I''ll write to Eric to find a clean way to address this. -- fxn PS: This patch does not fix the end-user doc:rails task by now, should be OK in final when it is clear what can we do about it. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Sat, Aug 7, 2010 at 3:31 PM, Xavier Noria <fxn@hashref.com> wrote:> In this set we distinguish two subsets, this one (1) > > railties/lib/rails/generators/erb.rb > actionpack/lib/action_view/template/handlers/erb.rbNah, I messed up here, these ones are not skipped. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Great, thanks for checking it out and figuring out a solution! On Sat, Aug 7, 2010 at 8:31 AM, Xavier Noria <fxn@hashref.com> wrote:> On Sat, Aug 7, 2010 at 2:38 AM, Xavier Noria <fxn@hashref.com> wrote: > >> On Fri, Aug 6, 2010 at 11:19 PM, Andrew Kaspick <akaspick@gmail.com> wrote: >> >>> Looking at http://edgeapi.rubyonrails.org/, I don''t see any docs for >>> AbstractController. Nothing appears for the layout method for >>> example. Am I missing something or does something need to be changed >>> in the docs to get them to appear? >> >> I''ve added Abstract Controller to the rdoc task, and some of it is >> already online. But for some reason AC::Layouts is not being >> generated. I''ll investigate it this weekend. > > Understood! > > It was fortunate that you were interested in > AbstractController::Layouts, investigating this has uncovered that the > following files were being excluded by RDoc: > > railties/lib/rails/generators/erb.rb > actionpack/lib/abstract_controller/layouts.rb > actionpack/lib/action_controller/caching/fragments.rb > actionpack/lib/action_controller/record_identifier.rb > actionpack/lib/action_view/base.rb > actionpack/lib/action_view/helpers/cache_helper.rb > actionpack/lib/action_view/helpers/capture_helper.rb > actionpack/lib/action_view/helpers/record_tag_helper.rb > actionpack/lib/action_view/helpers/text_helper.rb > actionpack/lib/action_view/render/layouts.rb > actionpack/lib/action_view/render/partials.rb > actionpack/lib/action_view/template/handlers/erb.rb > activesupport/lib/active_support/benchmarkable.rb > > In this set we distinguish two subsets, this one (1) > > railties/lib/rails/generators/erb.rb > actionpack/lib/action_view/template/handlers/erb.rb > > and the rest (2). > > Reason for (1) is that RDoc skips files whose name match /erb\.rb$/. > Explanation for (2) is that RDoc skips files that have 4 or more > occurrences of <%|%> in their first 1024 bytes (????). > > As a quick hack I''ve redefined RDoc::Parser.binary? in the very > Rakefile and regenerated the edge API, should be complete now. (I had > to tell Chrome to reload the frames, it''s in the contextual menu.) > > I''ll write to Eric to find a clean way to address this. > > -- fxn > > PS: This patch does not fix the end-user doc:rails task by now, should > be OK in final when it is clear what can we do about it. > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
As a side note, are you aware of the formatting issues for various sections? http://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many Looks like newlines are being ignored. On Sat, Aug 7, 2010 at 1:26 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> Great, thanks for checking it out and figuring out a solution! > > On Sat, Aug 7, 2010 at 8:31 AM, Xavier Noria <fxn@hashref.com> wrote: >> On Sat, Aug 7, 2010 at 2:38 AM, Xavier Noria <fxn@hashref.com> wrote: >> >>> On Fri, Aug 6, 2010 at 11:19 PM, Andrew Kaspick <akaspick@gmail.com> wrote: >>> >>>> Looking at http://edgeapi.rubyonrails.org/, I don''t see any docs for >>>> AbstractController. Nothing appears for the layout method for >>>> example. Am I missing something or does something need to be changed >>>> in the docs to get them to appear? >>> >>> I''ve added Abstract Controller to the rdoc task, and some of it is >>> already online. But for some reason AC::Layouts is not being >>> generated. I''ll investigate it this weekend. >> >> Understood! >> >> It was fortunate that you were interested in >> AbstractController::Layouts, investigating this has uncovered that the >> following files were being excluded by RDoc: >> >> railties/lib/rails/generators/erb.rb >> actionpack/lib/abstract_controller/layouts.rb >> actionpack/lib/action_controller/caching/fragments.rb >> actionpack/lib/action_controller/record_identifier.rb >> actionpack/lib/action_view/base.rb >> actionpack/lib/action_view/helpers/cache_helper.rb >> actionpack/lib/action_view/helpers/capture_helper.rb >> actionpack/lib/action_view/helpers/record_tag_helper.rb >> actionpack/lib/action_view/helpers/text_helper.rb >> actionpack/lib/action_view/render/layouts.rb >> actionpack/lib/action_view/render/partials.rb >> actionpack/lib/action_view/template/handlers/erb.rb >> activesupport/lib/active_support/benchmarkable.rb >> >> In this set we distinguish two subsets, this one (1) >> >> railties/lib/rails/generators/erb.rb >> actionpack/lib/action_view/template/handlers/erb.rb >> >> and the rest (2). >> >> Reason for (1) is that RDoc skips files whose name match /erb\.rb$/. >> Explanation for (2) is that RDoc skips files that have 4 or more >> occurrences of <%|%> in their first 1024 bytes (????). >> >> As a quick hack I''ve redefined RDoc::Parser.binary? in the very >> Rakefile and regenerated the edge API, should be complete now. (I had >> to tell Chrome to reload the frames, it''s in the contextual menu.) >> >> I''ll write to Eric to find a clean way to address this. >> >> -- fxn >> >> PS: This patch does not fix the end-user doc:rails task by now, should >> be OK in final when it is clear what can we do about it. >> >> -- >> You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. >> >> >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Sun, Aug 8, 2010 at 1:26 AM, Andrew Kaspick <akaspick@gmail.com> wrote:> As a side note, are you aware of the formatting issues for various sections? > > http://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many > > Looks like newlines are being ignored.This looks like a bug in horo, I will investigate it as well. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Sun, Aug 8, 2010 at 3:04 AM, Xavier Noria <fxn@hashref.com> wrote:> On Sun, Aug 8, 2010 at 1:26 AM, Andrew Kaspick <akaspick@gmail.com> wrote: > >> As a side note, are you aware of the formatting issues for various sections? >> >> http://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many >> >> Looks like newlines are being ignored. > > This looks like a bug in horo, I will investigate it as well.Fixed! -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Looks good! I took a look at the layout method (original issue) at http://edgeapi.rubyonrails.org/classes/AbstractController/Layouts/ClassMethods.html#method-i-layout and the formatting seems a bit off (things don''t line up correctly in places) and some of the docs are missing it seems. Is this due to the issues you mentioned before? Thanks On Sun, Aug 8, 2010 at 4:39 AM, Xavier Noria <fxn@hashref.com> wrote:> On Sun, Aug 8, 2010 at 3:04 AM, Xavier Noria <fxn@hashref.com> wrote: > >> On Sun, Aug 8, 2010 at 1:26 AM, Andrew Kaspick <akaspick@gmail.com> wrote: >> >>> As a side note, are you aware of the formatting issues for various sections? >>> >>> http://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many >>> >>> Looks like newlines are being ignored. >> >> This looks like a bug in horo, I will investigate it as well. > > Fixed! > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Sun, Aug 8, 2010 at 12:17 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> Looks good! > > I took a look at the layout method (original issue) at > http://edgeapi.rubyonrails.org/classes/AbstractController/Layouts/ClassMethods.html#method-i-layout > and the formatting seems a bit off (things don''t line up correctly in > places) and some of the docs are missing it seems. > > Is this due to the issues you mentioned before?I think that''s due to the markup itself. It uses labelled lists and stuff that does not follow the style of rest of the API. Some items are indented in a way that means to RDoc they are code blocks, but they aren''t... Those docs need to have the guidelines applied and have an edit pass in general. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Gotcha. Thanks for checking things out. On Sun, Aug 8, 2010 at 5:48 AM, Xavier Noria <fxn@hashref.com> wrote:> On Sun, Aug 8, 2010 at 12:17 PM, Andrew Kaspick <akaspick@gmail.com> wrote: > >> Looks good! >> >> I took a look at the layout method (original issue) at >> http://edgeapi.rubyonrails.org/classes/AbstractController/Layouts/ClassMethods.html#method-i-layout >> and the formatting seems a bit off (things don''t line up correctly in >> places) and some of the docs are missing it seems. >> >> Is this due to the issues you mentioned before? > > I think that''s due to the markup itself. It uses labelled lists and > stuff that does not follow the style of rest of the API. Some items > are indented in a way that means to RDoc they are code blocks, but > they aren''t... > > Those docs need to have the guidelines applied and have an edit pass in general. > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.