thr3ads.net - Rails core - Responders, JSON, and PUT requests [Aug 2010]

If this information is useful, please help other people find it:
Share via:

Michael Schuerig

2010-Aug-06 22:02 UTC

Responders, JSON, and PUT requests

When I use jQuery (1.4.2) to execute a PUT request

  $.ajax({
    url: urlc,
    type: ''PUT'', // POST + _method=''PUT''
makes no difference
    dataType: ''json'',
    data: data,

against a Rails (3.0.0.beta4) controller using respond_with

  def update
    @resource.update_attribute(...)
    respond_with(@resource)
  end

Then jQuery indicates an error even if Rails sends a success response.

Here''s what''s happening:
ActionController::Responder#api_behavior
responds with head :ok. Which in turn writes a response body containing 
a single space.

In the browser, jQuery, as requested, parses the response body, using 
its parseJSON function. If available, this function calls the native 
window.JSON.parse. Unfortunately, the later function, when called on the 
single space we got earlier, raises a SyntaxError. (It does the same on 
an empty string.)

I take it, the browser (Firefox 3.5.11) is to blame, but that doesn''t 
help much. The easiest solution would be if jQuery didn''t pass entirely
whitespace strings to window.JSON.parse. As a stop-gap measure, I''m 
patching jQuery like this

  var parseJSON_orig = $.parseJSON;
  $.parseJSON = function(data) {
    if (/^\s*$/.test(data)) {
      return null;
    } else {
      parseJSON_orig(data);
    }
  }

Is there any better way to get things working? Should jquery-ujs take 
care of this problem?

Michael


-- 
Michael Schuerig
mailto:michael@schuerig.de
http://www.schuerig.de/michael/

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.

Ivan Nastyukhin

2010-Aug-07 12:14 UTC

head link

Re: Responders, JSON, and PUT requests

No
It''s jquery bug
Sent from my iPad

On Aug 7, 2010, at 2:02 AM, Michael Schuerig <michael@schuerig.de> wrote:
> 
> When I use jQuery (1.4.2) to execute a PUT request
> 
>  $.ajax({
>    url: urlc,
>    type: ''PUT'', // POST + _method=''PUT''
makes no difference
>    dataType: ''json'',
>    data: data,
> 
> against a Rails (3.0.0.beta4) controller using respond_with
> 
>  def update
>    @resource.update_attribute(...)
>    respond_with(@resource)
>  end
> 
> Then jQuery indicates an error even if Rails sends a success response.
> 
> Here''s what''s happening:
ActionController::Responder#api_behavior
> responds with head :ok. Which in turn writes a response body containing 
> a single space.
> 
> In the browser, jQuery, as requested, parses the response body, using 
> its parseJSON function. If available, this function calls the native 
> window.JSON.parse. Unfortunately, the later function, when called on the 
> single space we got earlier, raises a SyntaxError. (It does the same on 
> an empty string.)
> 
> I take it, the browser (Firefox 3.5.11) is to blame, but that
doesn''t
> help much. The easiest solution would be if jQuery didn''t pass
entirely
> whitespace strings to window.JSON.parse. As a stop-gap measure,
I''m
> patching jQuery like this
> 
>  var parseJSON_orig = $.parseJSON;
>  $.parseJSON = function(data) {
>    if (/^\s*$/.test(data)) {
>      return null;
>    } else {
>      parseJSON_orig(data);
>    }
>  }
> 
> Is there any better way to get things working? Should jquery-ujs take 
> care of this problem?
> 
> Michael
> 
> 
> -- 
> Michael Schuerig
> mailto:michael@schuerig.de
> http://www.schuerig.de/michael/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
> For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
> 
-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.

Rails core - Aug 2010 - Responders, JSON, and PUT requests

Responders, JSON, and PUT requests

Re: Responders, JSON, and PUT requests