i am jbarket
2008-Apr-03 19:13 UTC
My first very minor patch. I would greatly appreciate some feedback, and verification that it does test fine for others.
The patch can be found here: http://dev.rubyonrails.org/ticket/11522 In the process of testing RoleRequirement (of which I am the most minor contributor in the world, but I''ve been trying to get things like this going to make larger improvements) on various applications, I often have a set of mirrored functional tests that are basically user-with-roles test and user-without-roles test where the first should succeed and the second should fail. Outside of verification that changes to the data aren''t made, the simplest way to verify things is to assert_response 401. I just thought it was silly that we''ve got existing Rails-esque keys for almost every other situation, but not for 401 (unauthorized) or 403 (forbidden), so I added the two. These are very, very minor changes, so if anyone has a moment to review what I''ve done and give me some feedback, I''d greatly appreciate it. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Mislav Marohnić
2008-Apr-03 20:21 UTC
Re: My first very minor patch. I would greatly appreciate some feedback, and verification that it does test fine for others.
When you close a new ticket as invalid, it would be cool if you could state the reason. I know that the patch is yours, but still ... Thanks On Thu, Apr 3, 2008 at 9:13 PM, i am jbarket <jbarket@gmail.com> wrote:> > The patch can be found here: http://dev.rubyonrails.org/ticket/11522 >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---