Michael Schoen
2007-Oct-07 06:32 UTC
Rails AR/Oracle Unit Test: [7771] failed (but getting better)
"bitsweat" has given AR/Oracle some love, but it''s still unhappy... http://dev.rubyonrails.org/changeset/7771 ------------------------------------------------------------------------ r7771 | bitsweat | 2007-10-06 23:27:39 -0700 (Sat, 06 Oct 2007) | 1 line Reinstate failsafe date/time parsing rescues. Head off some obvious failures like year == 0 or nil. ------------------------------------------------------------------------ U activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb U activerecord/lib/active_record/connection_adapters/mysql_adapter.rb Updated to revision 7771. 1) Failure: test_preserving_date_objects(BasicsTest) [./test/base_test.rb:387:in `test_preserving_date_objects'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'']: The last_read attribute should be of the Time class. <Thu, 15 Apr 2004> expected to be kind_of? <Time> but was <Date>. 2) Error: test_saves_both_date_and_time(DateTimeTest): RangeError: out of range of Time (expect between 1970-01-01 00:00:00 UTC and 2037-12-31 23:59:59, but 1807-10-06 23:30:58 PST) /usr/pkg/ruby184/lib/ruby/site_ruby/1.8/oci8.rb:983:in `to_time'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/activerecord-1.15.1/lib/active_record/connection_adapters/oracle_adapter.rb:503:in `select'' ./test/../lib/active_record/base.rb:1360:in `each_with_index'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/activerecord-1.15.1/lib/active_record/connection_adapters/oracle_adapter.rb:496:in `select'' ./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache'' ./test/../lib/active_record/connection_adapters/abstract/query_cache.rb:55:in `select_all'' ./test/../lib/active_record/base.rb:439:in `find_by_sql'' ./test/../lib/active_record/base.rb:1004:in `find_every'' ./test/../lib/active_record/base.rb:1035:in `find_one'' ./test/../lib/active_record/base.rb:1021:in `find_from_ids'' ./test/../lib/active_record/base.rb:431:in `find'' ./test/date_time_test.rb:13:in `test_saves_both_date_and_time'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'' 3) Error: test_joins_dont_clobber_id(FinderTest): ActiveRecord::StatementInvalid: OCIError: ORA-00905: missing keyword: select * from (select raw_sql_.*, rownum raw_rnum_ from (SELECT companies.* FROM companies INNER JOIN companies AS clients ON clients.firm_id = companies.id WHERE (companies.id = 1) AND ( (companies.type = ''Firm'' ) ) ) raw_sql_ where rownum <= 1) where raw_rnum_ > 0 ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:137:in `log'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/activerecord-1.15.1/lib/active_record/connection_adapters/oracle_adapter.rb:222:in `execute_without_counting'' ./test/abstract_unit.rb:70:in `execute'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/activerecord-1.15.1/lib/active_record/connection_adapters/oracle_adapter.rb:489:in `select'' ./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache'' ./test/../lib/active_record/connection_adapters/abstract/query_cache.rb:55:in `select_all'' ./test/../lib/active_record/base.rb:439:in `find_by_sql'' ./test/../lib/active_record/base.rb:1004:in `find_every'' ./test/../lib/active_record/base.rb:998:in `find_initial'' ./test/../lib/active_record/base.rb:429:in `find'' ./test/finder_test.rb:555:in `test_joins_dont_clobber_id'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'' 4) Error: test_select_rows(FinderTest): NotImplementedError: select_rows is an abstract method ./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:34:in `select_rows'' ./test/finder_test.rb:608:in `test_select_rows'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'' 5) Error: test_select_values(FinderTest): NotImplementedError: select_rows is an abstract method ./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:34:in `select_rows'' ./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:27:in `select_values'' ./test/finder_test.rb:599:in `test_select_values'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'' 6) Failure: test_binary_in_fixtures(FixturesTest) [./test/fixtures_test.rb:194:in `test_binary_in_fixtures'' /usr/pkg/ruby184/lib/ruby/gems/1.8/gems/mocha-0.5.1/lib/mocha/test_case_adapter.rb:19:in `run'']: <"\377\330\377\340\000\020JFIF\000\001\001\001\000H\000H\000\000\377\333\000C\000\010\006\006\a\006\005\010\a\a\a\t\t\010\n\f\024\r\f\v\v\f\031\022\023\017\024\035\032\037\036\035\032\034\034 $.'' \",#\034\034(7),01444\037''9=82<.342\377\333\000C\001\t\t\t\f\v\f\030\r\r\0302!\034!22222222222222222222222222222222222222222222222222\377\300\000\021\010\001^\001\a\003\001\"\000\002\021\001\003\021\001\377\304\000\034\000\000\002\003\001\001\001\001\000\000\000\000\000\000\000\000\000\000\005\003\004\006\002\a\001\010\377\304\000E\020\000\002\001\003\003\002\004\003\006\004\004\004\003\010\003\000\001\002\003\000\004\021\005\022!1A\006\023Qa\"q\201\0242\221\241\261\301\025#B\321$Rb\3413r\360\361\a\026C%4Scs\202\222\242D\262\322\377\304\000\032\001\000\003\001\001\001\001\000\000\000\000\000\000\0 00\000\000\000\000\002\003\001\004\005\006\377\304\000+\021\000\002\002\002\002\002\002\002\002\001\004\003\000\000\000\000\000\0 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---