Vorbis dev - Feb 2008 - [PATCH] vorbis-tools, various

Hi,

I've just downloaded vorbis-tools-1.2.0-RC4.tar.gz yesterday, and it
didn't build on
my machine, which, cunningly, has an old libvorbis.

The first two patches fix detection of libcurl (which is probably
rather old too), and
make oggenc build with my libvorbis. An old one, and I forgot to look
up its version,
and I'm not at home just now. It was before the advanced encoder options.

The third one adds kate support, if libkate's found, so you may or may
not decide to
apply it. That libkate API's stable though.

I noticed it afterwards, but the last hunk also fixes length check
bugs for a couple
magics, so you'll want this one.

Now, you want to have a look at the place that says "Look, without the
hands, ma",
because it's a place where I've taken out the advanced encoder stuff
to make it build,
but which I'm not sure should be replaced by something else for old
libvorbis. It seems
to encode fine for me, but YMMV, someone who knows well libvorbis should have a
look. It may be that it's fine as is, in which case just remove the printf.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-configure.diff
Type: text/x-patch
Size: 534 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-configure.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-kate.diff
Type: text/x-patch
Size: 14446 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-kate.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-old-libvorbis.diff
Type: text/x-patch
Size: 1920 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-old-libvorbis.bin

I'll look into the patches tomorrow.

I'm afraid not to roll the kate support in 1.2.0, though.  I will
confirm after studying the patch.

-Ivo

Regarding your libvorbis issue, can you check later what version you
have?  vorbis-tools requires the bare minimum of version 1.1.1.  That
is highly deprecated by now, and to commit all those ifdefs merely for
the people running a possibly even older version of libvorbis than
1.1.1 seems unwise.

Your libcurl issue I do not understand.  Do you really need another
check for curl to be able to compile the tools?

-Ivo

On 15/02/2008, Ivo Emanuel Gon?alves <justivo@gmail.com>
wrote:
> Regarding your libvorbis issue, can you check later what version you
>  have?  vorbis-tools requires the bare minimum of version 1.1.1.  That
>  is highly deprecated by now, and to commit all those ifdefs merely for
>  the people running a possibly even older version of libvorbis than
>  1.1.1 seems unwise.
Seems straightforward to me. Whether or not a project considers older
versions "deprecated" is irrelevent, the fact is they exist and this
code compiles against them with the trivial patches supplied.
>  Your libcurl issue I do not understand.  Do you really need another
>  check for curl to be able to compile the tools?
It allows for the case where the system pkg-config exists, but the
installed libcurl has not installed a pkg-config file.

I had a brief look over those patches, they look ok to me. It may make
sense to hold off on the Kate support for 1.2.0 as you suggested, as
that is experimental; and you probably want to simply remove the
printf in the last hunk.

Conrad.

> Regarding your libvorbis issue, can you check later what version you
> have? vorbis-tools requires the bare minimum of version 1.1.1. That
I will, sorry, I forgot to check again :)
> Your libcurl issue I do not understand. Do you really need another
> check for curl to be able to compile the tools?
As Conrad says I believe. I suppose old versions of libcurl did not use
pkgconfig.