Nouveau - Sep 2012 - [Bug 55310] New: incorrect rendering of some borders in certain gtk3 themes

https://bugs.freedesktop.org/show_bug.cgi?id=55310

          Priority: medium
            Bug ID: 55310
          Assignee: nouveau at lists.freedesktop.org
           Summary: incorrect rendering of some borders in certain gtk3
                    themes
        QA Contact: xorg-team at lists.x.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: sebastian-keller at gmx.de
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: Driver/nouveau
           Product: xorg

Created attachment 67669
  --> https://bugs.freedesktop.org/attachment.cgi?id=67669&action=edit
Screenshot showing the problem

When using a gtk3 theme that uses "border-image" with the
"stretch" as repeat
mode (such as Adwaita, the default theme), gtk3 uses cairo to scale the image.
When using the "image" backend of cairo everything looks as expected.
Using the
X backend on a "intel" driver should work as well (as I'm told).
But using the
"nouveau" driver gives some fading out borders.

After changing NV50EXAPictTexture to use CLAMP_TO_EDGE for RepeatPad like the
intel driver does
(http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/i915_render.c?id=c6008068372709c73034163eddc902b47bf87d24#n327)
the result looks like the one rendered with the "image" backend.

I'm attaching the patch and a screenshot that shows the rendering issue, how
it
looks with the image backend and after the patch.

For the screenshot I've made the top right pixel in the top border red
(#ff0000). In the first screenshot you can see how the color "fades
away"
because it gets blended with some transparent pixels when scaled. In the second
and third screenshot the rightmost pixel before the corner is #ff0000.

I've only tested the patch for nv50 but the nv40 one should work as well if
the
defines are correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20120925/6d7cba17/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=55310

--- Comment #1 from Sebastian Keller <sebastian-keller at gmx.de> ---
Created attachment 67670
  --> https://bugs.freedesktop.org/attachment.cgi?id=67670&action=edit
Patch to fix the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20120925/b289339e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=55310

Marcin Slusarz <marcin.slusarz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67669|text/plain                  |image/png
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20120925/ed61536e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=55310

Ben Skeggs <skeggsb at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ben Skeggs <skeggsb at gmail.com> ---
Thanks for the patch, I modified it slightly to fix nvc0_exa.c in the same way
and pushed it to git!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20120926/d7122198/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=55310

Rui Tiago Matos <tiagomatos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tiagomatos at gmail.com

--- Comment #3 from Rui Tiago Matos <tiagomatos at gmail.com> ---
*** Bug 41133 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20120926/16dd35fe/attachment-0001.html>