Darryl L. Pierce
2009-Jun-22 18:23 UTC
[Ovirt-devel] [PATCH node] Only allow initial networking to be configured. bz#507393
If an existing bridge configuration is detected, then an error message
is shown to the user and the script exits.
Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
---
scripts/ovirt-config-networking | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/scripts/ovirt-config-networking b/scripts/ovirt-config-networking
index d29bd12..4081a9d 100755
--- a/scripts/ovirt-config-networking
+++ b/scripts/ovirt-config-networking
@@ -26,6 +26,14 @@ if ! is_local_storage_configured; then
exit 99
fi
+# if the network is already configured, then exit the script
+ls /etc/sysconfig/network-scripts/ifcfg-br* > /dev/null 2>&1
+
+if [ $? -eq 0 ]; then
+ printf "\nExisting network configuration detected.
Aborting...\n\n"
+ exit 99
+fi
+
function configure_interface
{
local NIC=$1
--
1.6.0.6
Alan Pevec
2009-Jun-23 14:10 UTC
[Ovirt-devel] [PATCH node] Only allow initial networking to be configured. bz#507393
NAK, it should still be possible to reconfigure networking, but only from scratch - i.e. must start by selecting NIC and then DNS, NTP, earsing the old configuration. The actual bug is that configure_ntp modifies ntp.conf directly, it should be applied only when confirmed, as for the other configs. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090623/b6c62a69/attachment.htm>