Mohammed Morsi
2009-May-28 16:28 UTC
[Ovirt-devel] [PATCH node] correctly use collectd udp dns entry
---
scripts/ovirt | 2 +-
scripts/ovirt-config-collectd | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/ovirt b/scripts/ovirt
index 8296783..4a7cbc7 100755
--- a/scripts/ovirt
+++ b/scripts/ovirt
@@ -43,7 +43,7 @@ start() {
log "skipping ovirt-awake, oVirt identify service not
available"
fi
- find_srv collectd tcp
+ find_srv collectd udp
if [ -n "$SRV_HOST" -a -n "$SRV_PORT" ]; then
collectd_conf=/etc/collectd.conf
if [ -f $collectd_conf.in ]; then
diff --git a/scripts/ovirt-config-collectd b/scripts/ovirt-config-collectd
index e509e54..236ddaa 100755
--- a/scripts/ovirt-config-collectd
+++ b/scripts/ovirt-config-collectd
@@ -92,7 +92,7 @@ prompt_user() {
if [ "$1" = "AUTO" ]; then
if [ -z "$OVIRT_COLLECTD_SERVER" -o -z
"$OVIRT_COLLECTD_PORT" ]; then
printf "\nAttempting to locate remote collectd server..."
- find_srv collectd tcp
+ find_srv collectd udp
if [ -n "$SRV_SERVER" -a -n "$SRV_PORT" ]; then
printf "found! Using collectd server
'$SRV_SERVER:$SRV_PORT'.\n"
ovirt_collectd $SRV_SERVER $SRV_PORT
--
1.6.0.6
David Lutterkort
2009-May-28 17:53 UTC
[Ovirt-devel] [PATCH node] correctly use collectd udp dns entry
On Thu, 2009-05-28 at 12:28 -0400, Mohammed Morsi wrote:> --- > scripts/ovirt | 2 +- > scripts/ovirt-config-collectd | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)Since this seems to fix a BZ, please include the number of the bug in your commit message. David
Jason Guiditta
2009-May-28 22:22 UTC
[Ovirt-devel] [PATCH node] correctly use collectd udp dns entry
ACK, though I agree, update subject to have bz, move description into body On Thu, May 28, 2009 at 12:28 PM, Mohammed Morsi <mmorsi at redhat.com> wrote:> --- > scripts/ovirt | 2 +- > scripts/ovirt-config-collectd | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/ovirt b/scripts/ovirt > index 8296783..4a7cbc7 100755 > --- a/scripts/ovirt > +++ b/scripts/ovirt > @@ -43,7 +43,7 @@ start() { > log "skipping ovirt-awake, oVirt identify service not available" > fi > > - find_srv collectd tcp > + find_srv collectd udp > if [ -n "$SRV_HOST" -a -n "$SRV_PORT" ]; then > collectd_conf=/etc/collectd.conf > if [ -f $collectd_conf.in ]; then > diff --git a/scripts/ovirt-config-collectd b/scripts/ovirt-config-collectd > index e509e54..236ddaa 100755 > --- a/scripts/ovirt-config-collectd > +++ b/scripts/ovirt-config-collectd > @@ -92,7 +92,7 @@ prompt_user() { > if [ "$1" = "AUTO" ]; then > if [ -z "$OVIRT_COLLECTD_SERVER" -o -z "$OVIRT_COLLECTD_PORT" ]; then > printf "\nAttempting to locate remote collectd server..." > - find_srv collectd tcp > + find_srv collectd udp > if [ -n "$SRV_SERVER" -a -n "$SRV_PORT" ]; then > printf "found! Using collectd server > '$SRV_SERVER:$SRV_PORT'.\n" > ovirt_collectd $SRV_SERVER $SRV_PORT > -- > 1.6.0.6 > > _______________________________________________ > Ovirt-devel mailing list > Ovirt-devel at redhat.com > https://www.redhat.com/mailman/listinfo/ovirt-devel >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090528/57e22e4b/attachment.htm>
Seemingly Similar Threads
- [PATCH node] Fix SRV_SERVER for SRV_HOST to work with /etc/init.d/ovirt-functions
- [PATCH node] Add support for automatic remote logging on PXE ovirt-node
- [PATCH node] add collectd.py
- [PATCH] ovirt-awake runs alone now, doesn't need anymore to be lauch by /etc/init.d/ovirt
- fc12 node partially working