netfilter buglog - Jun 2011 - [Bug 720] New: iptables no longer compiles for Linux 2.4 because it uses linux/magic.h

http://bugzilla.netfilter.org/show_bug.cgi?id=720

           Summary: iptables no longer compiles for Linux 2.4 because it
                    uses linux/magic.h
           Product: iptables
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P3
         Component: iptables
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: kenkyee at excite.com
   Estimated Hours: 0.0


This header and the PROC_SUPER_MAGIC macro are only for Linux 2.6.
It's used by xtables.c.
I tried this with the latest iptables 1.4.11

xtables.c:35:52: error: linux/magic.h: No such file or directory
xtables.c: In function 'proc_file_exists':
xtables.c:389: error: 'PROC_SUPER_MAGIC' undeclared (first use in this
function)
xtables.c:389: error: (Each undeclared identifier is reported only once
xtables.c:389: error: for each function it appears in.)


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=720





--- Comment #1 from Ken Yee <kenkyee at excite.com>  2011-06-07 23:22:54
---
I looked under the git tree...this was added on 4/4/2011 by Maciej Zenczykowski
in the xtables.c file.  Will try building again w/ 1.4.10...


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=720


Jan Engelhardt <jengelh at medozas.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jengelh at medozas.de
         AssignedTo|netfilter-                  |jengelh at medozas.de
                   |buglog at lists.netfilter.org  |




--- Comment #2 from Jan Engelhardt <jengelh at medozas.de>  2011-06-24
20:08:51 ---
Serious people don't run 2.4 anymore, but if it makes you happy, does
/usr/include/linux/proc_fs.h exist and have the magic value? If so, we can add
an autoconf check.


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=720


Jan Engelhardt <jengelh at medozas.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Jan Engelhardt <jengelh at medozas.de>  2011-06-24
20:18:50 ---
http://dev.medozas.de/gitweb.cgi?p=iptables;a=commitdiff;h=3c871010888e1479ef8fca2048485b979ec2661a


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=720





--- Comment #4 from Ken Yee <kenkyee at excite.com>  2011-06-25 05:13:43
---
Thanks for fixing it.

FYI, I was porting iptables to an embedded system that is out in the field
already.  I'm not happy it's running 2.4 either.  Embedded legacy
systems
aren't as simple to upgrade to 2.6 :-(


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.