netfilter buglog - Apr 2011 - [Bug 713] New: CPPFLAGS are mishandled which breaks non-shared targets

http://bugzilla.netfilter.org/show_bug.cgi?id=713

           Summary: CPPFLAGS are mishandled which breaks non-shared targets
           Product: iptables
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: unknown
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: vapier at gentoo.org
   Estimated Hours: 0.0


Created an attachment (id=352)
 --> (http://bugzilla.netfilter.org/attachment.cgi?id=352)
0001-clean-up-CPPFLAGS-handling.patch

Currently, cpp flags are put into CFLAGS instead of CPPFLAGS.  Then with
a few specific libraries, some more cpp flags are added into the library
specific CFLAGS.  So at the moment, static-only systems break when the
NO_SHARED_LIBS define is used in files that don't have it explicitly in
the Makefile.

Rather than propagate these flags to the specific files that are failing,
redo the whole thing at the global level.  All the cpp flags are moved
out of AM_CFLAGS and into AM_CPPFLAGS, and NO_SHARED_LIBS is appended to
that variable.  This lets us drop the manual setting of library-specific
CFLAGS in a bunch of places while making sure it shouldn't break again
in the future.

patch attached


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713


Patrick McHardy <kaber at trash.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kaber at trash.net




--- Comment #1 from Patrick McHardy <kaber at trash.net>  2011-04-05
14:26:50 ---
Please submit the patch via netfilter-devel at vger.kernel.org.


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713


Jan Engelhardt <jengelh at medozas.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jengelh at medozas.de
         AssignedTo|netfilter-                  |jengelh at medozas.de
                   |buglog at lists.netfilter.org  |




-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713


Jan Engelhardt <jengelh at medozas.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713





--- Comment #2 from Jan Engelhardt <jengelh at medozas.de>  2011-06-01
02:17:06 ---
I cannot quite follow your problem description, but since CPPFLAGS should
indeed go to CPPFLAGS, I am (1)picking up the patch, at least in part.

A few things of note, but which you will not need to concern with due to (1):
regular_CFLAGS contains non-CPPFLAGS, so it must not be unanimously moved to
AM_CPPFLAGS. I had to split it up first.


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713





--- Comment #3 from Jan Engelhardt <jengelh at medozas.de>  2011-06-01
02:31:46 ---
Mike; I prepped a tree at git://dev.medozas.de/iptables master , so far.
What is it that fails compilation due to {libxtables,oraprogram}_CFLAGS to
contain -DNO_SHARED_LIBS=1?


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugzilla.netfilter.org/show_bug.cgi?id=713


Jan Engelhardt <jengelh at medozas.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.