Nouveau - Mar 2011 - [Bug 35441] New: header files (at least nouveau_device.h and nouveau_grojb.h) missing from git

https://bugs.freedesktop.org/show_bug.cgi?id=35441

           Summary: header files (at least nouveau_device.h and
                    nouveau_grojb.h) missing from git
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: Drivers/DRI/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: rwhite at pobox.com


The current git repository as of this date is missing at least two header files
referenced by src/mesa/drivers/dri/nouveau/nouveau_driver.h

The file nouveau_device.h is missing and when I just experimentally commented
that out then nouveau_gobj.h cropped up missing so I stopped.

All the other header files in the same block of includes that I could locate
are all apparently local to this directory. They are also all local includes
(e.g. in "" not <> quotes) so I figure they are all from here.

spot checking I think

nouveau_device.h, nouveau_grobj.h, nouveau_channel.h, and nouveau_notifier.h
and any .c files they front for are suspiciously missing or live somewhere
inobvious to me.

This was first observed about two weeks ago but I didn't realize this was
the
right place to report it. /doh.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #1 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-20 00:15:41 PDT ---
Created an attachment (id=44629)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44629
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=44629

a suitable patch

In file `src/mesa/drivers/dri/nouveau/Makefile.am' use `LIBDRM_CFLAGS'
instead
of just `CFLAGS': the pkg-config flags from `libdrm_nouveau.pc'
(installed by
`libdrm') must yield its `-I/usr/include/nouveau' where you find all
these
"missing" header files. (`INCLUDES' variable instead does not seem
to work).

c.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

????????? Gli?a ?????? <cglita at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44629|0                           |1
        is obsolete|                            |

--- Comment #2 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-24 02:49:54 PDT ---
Created an attachment (id=44779)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44779
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=44779

just nouveau *.pc

no need to for libdrm, see configs/linux-dri
(it was `../Makefile' not `../Makefile.am')

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

????????? Gli?a ?????? <cglita at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jordan.yelloz+fdo at gmail.com

--- Comment #3 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-24 02:56:53 PDT ---
*** Bug 35609 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

Francisco Jerez <currojerez at riseup.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chalserogers at gmail.com

--- Comment #4 from Francisco Jerez <currojerez at riseup.net> 2011-03-24
11:00:51 PDT ---
Apparently the problem is just that CFLAGS is not taken into account during the
DRI driver compilation when using "--enable-shared-dricore".

Christopher, was that the intended behavior of that option?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

????????? Gli?a ?????? <cglita at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44779|0                           |1
        is obsolete|                            |

--- Comment #5 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-25 01:36:40 PDT ---
Created an attachment (id=44812)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44812
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=44812

use pkgconfig in configure.ac and INCLUDES in Makefiles


- moved `+=' stuff after "include ../Makefile.template"

- placing stuff in configure.ac

shortcoming:
should consider for nouveau also nv50 etc. like for radeon r300 r600 ...

proposal:
split `Makefile.template' into `Makefile.common' and
`Makefile.targets'

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #6 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-25 01:38:48 PDT ---
Created an attachment (id=44813)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44813
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=44813

uses pkgconfig in configure.ac and configure and INCLUDES in Makefiles

same patch but added stuff also for `configure' script

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #7 from Peter Hjalmarsson <xake at rymdraket.net> 2011-03-27
04:51:33 PDT ---
(From update of attachment 44813)
Emm, why rename the radeon variable?


-RADEON_LIBS = `pkg-config --libs libdrm_radeon`
+NOUVEAU_LIBS = `shell pkg-config libdrm_nouveau --libs`
+NOUVEAU_CFLAGS = `shell pkg-config libdrm_nouveau --cflags`
+
+RADEON_LDFLAGS = `pkg-config --libs libdrm_radeon`

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #8 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-27 12:44:29 PDT ---
(In reply to comment #7)
> (From update of attachment 44813 [details])
> Emm, why rename the radeon variable?
> 
> 
> -RADEON_LIBS = `pkg-config --libs libdrm_radeon`
> +NOUVEAU_LIBS = `shell pkg-config libdrm_nouveau --libs`
> +NOUVEAU_CFLAGS = `shell pkg-config libdrm_nouveau --cflags`
> +
> +RADEON_LDFLAGS = `pkg-config --libs libdrm_radeon`
It seemed as a bug w.r.t. uninformed use in all Makefiles.

RADEON_LIBS looks like gone (not LIBDRM_RADEON_LIBS though with one occurence
in `configure.ac':1053); it's not coming from normal PKG_CHECK_MODULES
m4
macro: LIBDRM_RADEON_* do in lines 870-873, and then are read in lines
1052-1053.

Is this better?

-RADEON_LIBS = `pkg-config --libs libdrm_radeon`
-RADEON_CFLAGS = `pkg-config --cflags libdrm_radeon`
+LIBDRM_RADEON_LIBS = `pkg-config --libs libdrm_radeon`
+LIBDRM_RADEON_CFLAGS = `pkg-config --cflags libdrm_radeon`
+RADEON_CFLAGS = "-DHAVE_LIBDRM_RADEON=1 $LIBDRM_RADEON_CFLAGS"
+RADEON_LDFLAGS = "$LIBDRM_RADEON_LIBS"

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

????????? Gli?a ?????? <cglita at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44812|0                           |1
        is obsolete|                            |

--- Comment #9 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-29 09:30:05 PDT ---
Created an attachment (id=45008)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45008
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=45008

use pkgconfig in configure.ac and INCLUDES in Makefiles

configs/linux-dri is a makefile

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

????????? Gli?a ?????? <cglita at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44813|0                           |1
        is obsolete|                            |

--- Comment #10 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-29 09:31:01 PDT ---
Created an attachment (id=45009)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45009
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=45009

uses pkgconfig in configure.ac and configure and INCLUDES in Makefiles

configs/linux-dri is a makefile

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #11 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-30 03:57:03 PDT ---
Created an attachment (id=45037)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45037
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=45037

split Makefile.template and use pkgconfig in configure.ac and INCLUDES in
Makefiles

split `Makefile.template' into `Makefile.defines' and
`Makefile.targets'

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

--- Comment #12 from ????????? Gli?a ?????? <cglita at yahoo.com>
2011-03-30 03:58:57 PDT ---
Created an attachment (id=45038)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45038
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=45038

split Makefile.template and use pkgconfig in configure.ac and configure and
INCLUDES in Makefiles

split `Makefile.template' into `Makefile.defines' and
`Makefile.targets'

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

Fabio Pedretti <fabio.ped at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johannesobermayr at gmx.de

--- Comment #13 from Fabio Pedretti <fabio.ped at libero.it> 2011-05-13
00:00:18 PDT ---
*** Bug 37147 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

Johannes Obermayr <johannesobermayr at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45008|0                           |1
        is obsolete|                            |
  Attachment #45009|0                           |1
        is obsolete|                            |
  Attachment #45037|0                           |1
        is obsolete|                            |
  Attachment #45038|0                           |1
        is obsolete|                            |

--- Comment #14 from Johannes Obermayr <johannesobermayr at gmx.de>
2011-05-14 10:58:48 PDT ---
Created an attachment (id=46722)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46722
 Review: https://bugs.freedesktop.org/review?bug=35441&attachment=46722

Final fix!

This patches fixes whole compiling.

Tested on openSUSE (with and without --enable-shared-dricore).

https://build.opensuse.org/package/show?package=Mesa&project=home%3Ajobermayr
(with --enable-shared-dricore)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35441

Johannes Obermayr <johannesobermayr at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|header files (at least      |[PATCH] Mesa does not find
                   |nouveau_device.h and        |nouveau include files with
                   |nouveau_grojb.h) missing    |--enable-shared-dricore
                   |from git                    |
             Status|NEW                         |ASSIGNED
           Severity|major                       |critical
           Priority|medium                      |highest
          Component|Drivers/DRI/nouveau         |Mesa core
         AssignedTo|nouveau at lists.freedesktop.o |mesa-dev at
lists.freedesktop.
                   |rg                          |org

--- Comment #15 from Johannes Obermayr <johannesobermayr at gmx.de>
2011-05-14 11:01:46 PDT ---
Set 'Component: Mesa core' since the patch touches core parts.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.