It is more general. Any expression tree node that holds on a list of Expressions
could (should ultimately) have its factory there, not just MethodCall.
Tomas
From: Dino Viehland
Sent: Wednesday, January 27, 2010 10:36 AM
To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: Symbols and YAML
Shouldn''t ExpressionCollectionBuilder be more appropriately called
CallExpressionBuilder? Other than that looks fine.
From: Tomas Matousek
Sent: Wednesday, January 27, 2010 10:27 AM
To: IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: Symbols and YAML
tfpt review /shelveset:RSym14;tomat
DLR:
Adds ExpressionCollectionBuilder as a specialization of
ExpressionCollectionBuilder<Expression>.
Ruby:
Replaces SymbolId usage by RubySymbol class. Ruby symbols are possibly encoded
interned frozen strings.
Enables KCODE on Silverlight.
Allows class reopening in libraries (a class defined in Ruby can be reopened by
a library class).
Fixes bunch of bugs in YAML.
Fixes
http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3466
Tomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100127/190e770f/attachment-0001.html>