tfpt review "/shelveset:Basename;REDMOND\tomat" File.basename fix Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: Basename.diff Type: application/octet-stream Size: 8028 bytes Desc: Basename.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100127/fe0194ec/attachment.obj>
Looks good. -----Original Message----- From: Tomas Matousek Sent: Wednesday, January 27, 2010 3:48 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: Basename tfpt review "/shelveset:Basename;REDMOND\tomat" File.basename fix Tomas
Doesn''t case sensitive need to be true for Unix and OS X? JD -----Original Message----- From: Shri Borde Sent: Wednesday, January 27, 2010 4:01 PM To: Tomas Matousek; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: Basename Looks good. -----Original Message----- From: Tomas Matousek Sent: Wednesday, January 27, 2010 3:48 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: Basename tfpt review "/shelveset:Basename;REDMOND\tomat" File.basename fix Tomas