openssh unix dev - Jan 2012 - PATCH: Fix memory leak in sshd

Hello,

The below patch fixes a memory leak I noticed in monitor_read_load() when the
child's log pipe is closed.

Thanks,
Zev Weiss
--

diff --git a/monitor.c b/monitor.c
index a166fed..6464eec 100644
--- a/monitor.c
+++ b/monitor.c
@@ -510,6 +510,7 @@ monitor_read_log(struct monitor *pmonitor)
 			debug("%s: child log fd closed", __func__);
 			close(pmonitor->m_log_recvfd);
 			pmonitor->m_log_recvfd = -1;
+			buffer_free(&logmsg);
 			return -1;
 		}
 		fatal("%s: log fd read: %s", __func__, strerror(errno));

thanks for the report. Damien fixed that bug some weeks ago.

-m



On Sat, Jan 28, 2012 at 10:30 AM, Zev Weiss <zevweiss at gmail.com>
wrote:
> Hello,
>
> The below patch fixes a memory leak I noticed in monitor_read_load() when
the child's log pipe is closed.
>
> Thanks,
> Zev Weiss
> --
>
> diff --git a/monitor.c b/monitor.c
> index a166fed..6464eec 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -510,6 +510,7 @@ monitor_read_log(struct monitor *pmonitor)
> ? ? ? ? ? ? ? ? ? ? ? ?debug("%s: child log fd closed",
__func__);
> ? ? ? ? ? ? ? ? ? ? ? ?close(pmonitor->m_log_recvfd);
> ? ? ? ? ? ? ? ? ? ? ? ?pmonitor->m_log_recvfd = -1;
> + ? ? ? ? ? ? ? ? ? ? ? buffer_free(&logmsg);
> ? ? ? ? ? ? ? ? ? ? ? ?return -1;
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?fatal("%s: log fd read: %s", __func__,
strerror(errno));
>
>
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev at mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev