rsync - Sep 2007 - DO NOT REPLY [Bug 4957] New: rsync with acl patch crashes with fuzzy option

https://bugzilla.samba.org/show_bug.cgi?id=4957

           Summary: rsync with acl patch crashes with fuzzy option
           Product: rsync
           Version: 2.6.9
          Platform: x64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: ro@suse.de
         QAContact: rsync-qa@samba.org


#rm -r test1 test2
#mkdir test1
#echo foo > test1/t
#rsync --acls --fuzzy -a test1 test2
(first one works)
#rsync --acls --fuzzy -a test1 test2
rsync: connection unexpectedly closed (8 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at io.c(453)
[sender=2.6.9]

#dmesg | tail -n 1
rsync[32093] trap stack segment rip:41d89f rsp:7fff3c9e8e90 error:0


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4957





------- Comment #1 from ro@suse.de  2007-09-07 03:37 CST -------
since the subject may be a bit cryptic:
this happens with plain 2.6.8 / 2.6.9 plus the acl patch applied,
I've been able to narrow it down that far. (other patches can be applied
but are not necessary to reproduce the problem).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4957





------- Comment #2 from ro@suse.de  2007-09-07 06:02 CST -------
at least in 2.6.8+acl_patch, this seems to cure the problem:
--- acls.c
+++ acls.c
@@ -455,7 +455,7 @@
        do {
                int index;
                rsync_acl_list *racl_list = rsync_acl_lists(type);
-               if (f == -1) {
+               if (f == -1 || f == -2) {
                        rsync_acl_free(curr_racl);
                        continue;
                }

not sure if this is the correct solution though.

for 2.6.9 I have no idea yet, send_acl does not even check for "f ==
-1"
in 2.6.9, far less for -2.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4957





------- Comment #3 from wayned@samba.org  2007-09-07 18:56 CST -------
For 2.6.8, you could simplify your patch by just checking for "f <
0".

For 2.6.9, make sure you have this patch installed for ACL use:

http://lists.samba.org/archive/rsync/2006-November/016706.html

See the reply if you have the xattrs patch installed.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4957





------- Comment #4 from ro@suse.de  2007-09-10 09:55 CST -------
ah, perfect. thanks for the confirmation and the hint about 2.6.9!

if there is no issue with 3.0, you can probably close this one.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4957


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from wayned@samba.org  2007-09-10 21:00 CST -------
excellent.  Closing.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.