samba-bugs@samba.org
2006-Aug-02 14:13 UTC
DO NOT REPLY [Bug 3988] New: -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
Summary: -a collides with --flags
Product: rsync
Version: 2.6.8
Platform: x86
OS/Version: FreeBSD
Status: NEW
Severity: normal
Priority: P3
Component: core
AssignedTo: wayned@samba.org
ReportedBy: rsync@oldach.net
QAContact: rsync-qa@samba.org
On FreeBSD at least, -a --flags does not perform the intended function:
# touch f1
# chflags schg f1
# mkdir dest
# rsync -axvH --flags f1 dest
building file list ... done
f1
rsync: rename "/tmp/dest/.f1.Isi7Bm" -> "f1": Operation
not permitted (1)
sent 91 bytes received 42 bytes 266.00 bytes/sec
total size is 0 speedup is 0.00
rsync error: some files could not be transferred (code 23) at main.c(892)
[sender=2.6.8]
# ls -latro dest
total 4
-rw-r--r-- 1 root wheel schg 0 Aug 2 15:36 .f1.Isi7Bm
drwxrwxrwt 8 root wheel - 512 Aug 2 15:36 ..
drwxr-xr-x 2 root wheel - 512 Aug 2 15:36 .
#
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Sep-24 21:25 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
xfb52@dial.pipex.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xfb52@dial.pipex.com
------- Comment #1 from xfb52@dial.pipex.com 2006-09-24 16:25 MST -------
Same problem; -a not needed; just trying to rsync a file with
certain flags fails the same way. Looks like rsync sets the flags
on the transferred temporary copy but FreeBSD flags like
schg or nouunlnk prevent the temporary copy from being renamed.
Can the flags be set after the rename?
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-15 18:06 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #2 from wayned@samba.org 2006-10-15 13:06 MST -------
The latest CVS has a revised version of the flags.diff patch that I believe
should take care of this. The patch compiles on NetBSD, but I have no way to
test it (since chflags isn't cooperating).
http://rsync.samba.org/ftp/unpacked/rsync/patches/flags.diff
Apply that to 2.6.9pre2 and let me know if there is still an error.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-15 22:09 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
rsync@oldach.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rsync@oldach.net
Status|CLOSED |REOPENED
Resolution|FIXED |
------- Comment #3 from rsync@oldach.net 2006-10-15 17:08 MST -------
I did apply this patch to 2.6.8 with a minor patch modification. But it
doesn't
work:
# touch f1
# chflags schg f1
# mkdir dest
# rsync -axvH --flags f1 dest
rsync: file flags are not supported on this client
rsync error: syntax or usage error (code 1) at main.c(1231) [client=2.6.8]
#
I don't see any indication that the patch will apply to 2.6.9pre2 only. Or
is
there?
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-15 22:36 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988 ------- Comment #4 from hashproduct+rsync@gmail.com 2006-10-15 17:35 MST ------- (In reply to comment #3)> rsync: file flags are not supported on this client > rsync error: syntax or usage error (code 1) at main.c(1231) [client=2.6.8]Be sure to run autoconf and ./configure after applying the patch. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-16 05:30 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988 ------- Comment #5 from rsync@oldach.net 2006-10-16 00:30 MST ------- OK. This new patch doesn't actually *replace* patches/flags.diff... but autoconf & autoheader solved it. However the original problem remains: # touch f1 # chflags schg f1 # mkdir dest # rsync -axvH --flags f1 dest building file list ... done f1 rsync: failed to set file flags on "/tmp/q/dest/f1": No such file or directory (2) rsync: rename "/tmp/q/dest/.f1.JITFX8" -> "f1": Operation not permitted (1) sent 91 bytes received 42 bytes 88.67 bytes/sec total size is 0 speedup is 0.00 rsync error: some files could not be transferred (code 23) at main.c(977) [sender=2.6.9pre2] # -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-16 07:12 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
------- Comment #6 from wayned@samba.org 2006-10-16 02:11 MST -------
The call to make_mutable() was using fname when it should have used fnametmp.
The latest patch in CVS fixes this.
The code does not try to allow an immutable file in the destination to be
updated, and I assume that's how things should work.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Oct-16 07:38 UTC
DO NOT REPLY [Bug 3988] -a collides with --flags
https://bugzilla.samba.org/show_bug.cgi?id=3988
rsync@oldach.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
------- Comment #7 from rsync@oldach.net 2006-10-16 02:38 MST -------
Yep. This indeed fixes the original bug. Thanks!
However, I disagree on handling an immutable destination file upon update,
specifically when using the --archive option. A naive user would expect a
verbatim one-to-one copy of his files to the destination, including all file
characteristics like time, permissions, etc. For example, I use rsync to make
file system backups to a secondary disk and I want the "schg" flags
(e.g. on
mandatory shared libraries) to be copied over cleanly, regardless of an already
existing flag on the destination. In that respect, --perm and --flags currently
follow a different paradigm. Which is a POLA violation IMHO.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.