samba-bugs@samba.org
2005-Feb-14 08:41 UTC
[Bug 2187] rsync large file getting verification failed using -z
https://bugzilla.samba.org/show_bug.cgi?id=2187
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From wayned@samba.org 2005-02-14 01:35 -------
Checked fix into CVS.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2005-Feb-14 08:41 UTC
[Bug 2187] rsync large file getting verification failed using -z
https://bugzilla.samba.org/show_bug.cgi?id=2187 ------- Additional Comments From wayned@samba.org 2005-02-14 01:35 ------- Created an attachment (id=965) --> (https://bugzilla.samba.org/attachment.cgi?id=965&action=view) Fix problem with implicit (unsent) data I was able to reproduce your test case (much appreciated!) and the result is the fix in the attached patch. Apparently the zlib data handling is sensitive to how the implicit (unsent) data is broken up. The receiving side is kluging up a literal-data zlib header for unsent data, and this must be 65535 bytes or less in length. The sending side was throwing a whole block of data at the deflate() call, which apparently creates a potential mismatch in the data streams if the blocksize is larger than 65535 bytes. I changed the code to break up the blocks on the sending side in the same increments that the receiving side uses, and it fixed the problem. I hope the fix works for all large block sizes that were having a problem. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.