rsync - Oct 2004 - [Bug 1900] rsync --daemon hangs with --numeric-ids

https://bugzilla.samba.org/show_bug.cgi?id=1900


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned@samba.org  2004-10-11 03:56 -------
The problem is that the --numeric-ids option is a client option, not a server
option, so setting it on the server side creates confusion in what the client is
going to send over the wire.

The proper solution is to separate the parsing of daemon mode from normal rsync
mode so that client options cannot be specified when starting a daemon, and also
so that daemon options cannot be specified when starting a client.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1900





------- Additional Comments From wayned@samba.org  2004-10-11 04:01 -------
Created an attachment (id=717)
 --> (https://bugzilla.samba.org/attachment.cgi?id=717&action=view)
Change option parsing

This patch separates the daemon-mode's option parsing from the normal
client/server's option parsing.  It also separates the options in the usage
message (requiring the user to use "rsync --daemon --help" to see the
daemon
options).

Lightly tested, including daemon mode over ssh.  Need to double-check option
parsing separation to ensure I didn't miss anything.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1900


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2004-10-14 12:19 -------
I checked in a slightly modified version of the attached patch that will no
longer allow a daemon to be started with non-daemon options specified.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.