Nut upsdev - Jun 2008 - [nut-commits] svn commit r1502 - in trunk: . drivers man

Hi,

When running a driver with "-h" or without parameters, the
upsdrv_cleanup function seems to be called (which caused the warning I
mention in the ChangeLog). This doesn't seem right.

Regards,

On Sat, Jun 28, 2008 at 7:47 PM, Carlos Rodrigues
<carlosefr-guest at alioth.debian.org> wrote:
> Author: carlosefr-guest
> Date: Sat Jun 28 18:47:17 2008
> New Revision: 1502
>
> Log:
>  * drivers/megatec.c:
>   - Add parameters to set DTR and RTS explicitly in case the default values
>     don't work.
>   - Allow the UPS load value to be undefined.
>   - Send an "I" command before detection because some models seem
to
>     require it.
>   - Do nothing in upsdrv_cleanup if the file descriptor is invalid (to shut
>     up a warning displayed when running "megatec -h").
-- 
Carlos Rodrigues

> When running a driver with "-h" or without parameters, the
> upsdrv_cleanup function seems to be called (which caused the warning I
> mention in the ChangeLog). This doesn't seem right.
You're absolutely right. The change you made should be in the
exit_cleanup() function in main.c, not in the megatec.c file. Probably all
drivers will suffer from the same problem.

Best regards, Arjen
-- 
Eindhoven - The Netherlands
Key fingerprint - 66 4E 03 2C 9D B5 CB 9B  7A FE 7E C1 EE 88 BC 57