please keep the list cc'ed when replying me. ---------- Forwarded message ---------- From: Andreas Thienemann <andreas@bawue.net> Date: 15 nov. 2005 15:36 Subject: Re: RE New xanto driver for NUT To: Arnaud Quette <aquette.dev@gmail.com> Hello Arnaud, On Tue, 15 Nov 2005, Arnaud Quette wrote:> is there really a need to separate it from the megatec. > we're currently trying to merge similar drivers into the megatec to > simplify maintainance.I read about that. Unfortunately, I do belive it is necessary. The megatec protocol is used, but with some modifications of some commands. As there is absolutely no way of asking the UPS about manufacturer or model data, adding these models to the generic megatec driver would result in introducing special cases just for these models. I think, this is rather a nuissance.> - subscribe to the upsdev mailing list: > https://alioth.debian.org/mail/?group_id=30602 > > - post a patch (unified format, ie using diff -Nru orig.nut mod.nut > > your_patch) > to upsdev mentionning the more info possible (why you forked, ...) > > - wait for the feedback. Once approved, support is merged in > the CVS Development tree, and propagated to Testing then Stable...thanks. will do that, as soon as the code is ready for prime time. I have to cleanup one or two sscanf calls first. bye, andreas -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ OpenSource Developer - http://arnaud.quette.free.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20051115/2e46c740/attachment.html
On 11/15/05, Arnaud Quette <aquette.dev@gmail.com> wrote:> Unfortunately, I do belive it is necessary. > The megatec protocol is used, but with some modifications of some > commands. > As there is absolutely no way of asking the UPS about manufacturer or > model data, adding these models to the generic megatec driver would result > in introducing special cases just for these models. > > I think, this is rather a nuissance.Hmmm, can you give some examples of commands that behave differently between "megatec" and "xanto"? If it is sufficiently different I guess it cound be a separate driver. This protocol is used by many manufacturers, and most of them (beyond the low-end models) introduce variations of some sort, so there are going to be some special cases... The real question is: how does the current "megatec" driver handle it now? Does it barely work or doesn't it work at all (or behaves unacceptably wrong)? If it does work but shows wrong values for the battery charge, and other informational stuff, depending on how far the variations go (as I said above), some special cases could be implemented by passing an argument to the driver specifying the hardware (currently it doesn't have one, because it is only at the "eliminate redundant drivers" stage). The bottom line is seeing if the code sharing gains really are dwarfed by the special cases losses. BTW, are you starting from scratch or did you fork an existing driver? -- Carlos Rodrigues (megatec)
[I forgot to cc the list...] ---------- Forwarded message ---------- From: Arnaud Quette <aquette.dev@gmail.com> Date: 19 nov. 2005 20:09 Subject: Re: Mailing list garbage To: "Viktor T. Toth" <vttoth@vttoth.com> 2005/11/17, Viktor T. Toth <vttoth@vttoth.com>:> > Hey, aren't the nut-upsdev and nut-upsuser lists moderated/subscription > only? Why am I getting truckloads of (Korean? Chinese?) SPAM through these > lists now? Shouldn't the lists be configured to just not accept incoming > traffic from non-subscribers?these lists are moderated, so there is something wrong! But I don't know what's going on, so I've logged a request: http://tinyurl.com/clwcc Sorry to complain, but I was away from my desk a couple of hours, and by the> time I got back, I had 7 SPAM messages in my Inbox already, all from the NUT > lists.no problem. Spam is the most annoying internet thing I know Arnaud -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ OpenSource Developer - http://arnaud.quette.free.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.alioth.debian.org/pipermail/nut-upsuser/attachments/20051119/3940743f/attachment.htm