openssh unix dev - Jun 2002 - [Bug 282] ttymodes sent can be invalid

http://bugzilla.mindrot.org/show_bug.cgi?id=282





------- Additional Comments From stevesk at pobox.com  2002-06-22 06:15 -------
what kernel and glibc version?

try with "stty -parenb" on client side.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=282





------- Additional Comments From todd at openbsd.org  2002-06-22 06:43 -------
 Client is OpenBSD, server is Linux. 
 
Using 'stty -parenb' on OpenBSD this does not log the problem on the
Linux server.
 
todd at cvis1:~> rpm -qa | egrep "glibc-2|^k_" 
k_deflt-2.4.10-12 
glibc-2.2.4-64 
todd at cvis1:~>  
 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=282





------- Additional Comments From stevesk at pobox.com  2002-06-22 07:59 -------
can a glibc/linux person look at
sysdeps/unix/sysv/linux/tcsetattr.c and debug this?

this code is interesting:

 if (retval == 0 && cmd == TCSETS)
    {
      /* The Linux kernel has a bug which silently ignore the invalid
	 c_cflag on pty. We have to check it here. */



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=282





------- Additional Comments From stuge-openssh-bugzilla at cdy.org  2002-06-22
16:48 -------
/usr/src/linux/drivers/char/pty.c:345 reads

static void pty_set_termios(struct tty_struct *tty, struct termios *old_termios)
{
        tty->termios->c_cflag &= ~(CSIZE | PARENB);
        tty->termios->c_cflag |= (CS8 | CREAD);
}

This gets called when someone does tcsetattr() on a pty.  I think I can see a
reason for clearing CSIZE and setting CS8|CREAD, but why clear PARENB?

And in the glibc code quoted by Kevin this behaviour is referred to as if it
should return some error contrary to the current 'silently ignore'
approach..

What do kernel gurus on/from LKML say?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=282





------- Additional Comments From stevesk at pobox.com  2002-07-18 16:14 -------
a linux person needs to dig into this one



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.