openssh bugs - Mar 2011 - [Bug 1875] New: Gentoo QA warning: net-misc/openssh-5.8_p1-r1: closefromtest.c:46: warning: implicit declaration of function ‘closefrom’

https://bugzilla.mindrot.org/show_bug.cgi?id=1875

           Summary: Gentoo QA warning: net-misc/openssh-5.8_p1-r1:
                    closefromtest.c:46: warning: implicit declaration of
                    function ?closefrom?
           Product: Portable OpenSSH
           Version: 5.8p1
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Build system
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: mrdanwallis at gmail.com


When installing the net-misc/openssh-5.8_p1-r1 package on my Gentoo
system, I received the following notification:

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * closefromtest.c:46: warning: implicit declaration of function
?closefrom?

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.openssh.org/
 * ERROR: net-misc/openssh-5.8_p1-r1 failed:
 *   install aborted due to poor programming practices shown above



Looking through the build output, here is the warning in context:

make[1]: Leaving directory
`/var/tmp/portage/net-misc/openssh-5.8_p1-r1/work/openssh-5.8p1/openbsd-compat'
(cd openbsd-compat/regress && make)
make[1]: Entering directory
`/var/tmp/portage/net-misc/openssh-5.8_p1-r1/work/openssh-5.8p1/openbsd-compat/regress'
i686-pc-linux-gnu-gcc -O2 -march=i686 -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign
-Wno-unused-result -fno-strict-ali
asing -fno-builtin-memset -fstack-protector-all  -I. -I.. -I. -I./.. 
-DHAVE_CONFIG_H -Wl,-O1 -Wl,--as-needed -fstack-protector-all -Wl,-O1
-Wl,--as-needed ../libopenb
sd-compat.a -o closefromtest closefromtest.c ../libopenbsd-compat.a
-lresolv -lssl -lcrypto -ldl -lz   -ldl -lldap -lutil -lz -lnsl 
-lcrypt
closefromtest.c: In function ?main?:
closefromtest.c:46: warning: implicit declaration of function
?closefrom?
At top level:
cc1: warning: unrecognized command line option "-Wno-unused-result"
i686-pc-linux-gnu-gcc -O2 -march=i686 -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign
-Wno-unused-result -fno-strict-aliasing -fno-builtin-memset
-fstack-protector-all  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -Wl,-O1
-Wl,--as-needed -fstack-protector-all -Wl,-O1 -Wl,--as-needed
../libopenbsd-compat.a -o snprintftest snprintftest.c
../libopenbsd-compat.a -lresolv -lssl -lcrypto -ldl -lz   -ldl -lldap
-lutil -lz -lnsl  -lcrypt

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1875

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au

--- Comment #1 from Damien Miller <djm at mindrot.org> 2011-04-19 15:58:36
EST ---
Darren, can we just add a closefrom() prototype to the top of the file?
I.e.

int closefrom(int);

I can't imagine it being prototyped any other way.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1875

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1845
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2011-05-06
10:44:27 EST ---
Done and committed, it will be in the 5.9 release.

Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1875

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> 2011-09-06 15:32:59
EST ---
close resolved bugs now that openssh-5.9 has been released

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.