openssh bugs - Nov 2010 - [Bug 1213] ssh-keyscan exits in mid-way

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

--- Comment #3 from aab at purdue.edu 2010-11-23 12:00:50 EST ---
Created attachment 1961
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1961
One attempt at getting the rsa key from a remote server that was having
a number of problems.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

aab at purdue.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aab at purdue.edu

--- Comment #4 from aab at purdue.edu 2010-11-23 12:04:06 EST ---
I believe I've encountered the same or similar ssh-keyscan problem.
local ssh  - OpenSSH_5.1p1 Debian-5, OpenSSL 0.9.8g 19 Oct 2007
remote ssh - OpenSSH_4.3p2, OpenSSL 0.9.8e-fips-rhel5 01 Jul 2008
The remote server was having "problems": 1) no connection; 2)
connection and key returned; or 3) connection but hanging until remote
time out and
disconnect.  With the latter, ssh-keyscan aborted immediately with
exit-code=255 (see attachment).

I disagree with the original poster in that I think that ssh-keyscan
should continue in all cases except for an internal error.  In our
case, ssh-keyscan is buried several layers deep in wrapper scripts
where it is being fed (today) 3690+ host names.  Per the man pages, I
was expecting it to continue regardless of what the remote servers did
or didn't do.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

--- Comment #5 from aab at purdue.edu 2010-12-03 11:19:46 EST ---
Created attachment 1969
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1969
Fix(?) for premature ssh-keyscan abort.

This adds a local/static `cleanup_exit()' function to ssh-keyscan so
that aborts in non-ssh-keyscan code can be converted to "continue"s
while the `dispatch_run()' function is being executed.  It mimics the
already extant local/static `fatal()' function in using `exit()'
instead of the `_exit()' used in the default cleanup.c.

Two observations:
1) I also incremented the `howmany()' argument #1 count by 1.  This is
probably unnecessary but I note that all other occasions where
`howmany()' is used do this (and I'm chicken ...).
2) The current local/static `fatal()' function could possibly be
removed and the default one, defined in fatal.c, be used.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.