Michael Schoen
2006-Apr-28 01:02 UTC
Rails AR/Oracle Unit Test: [4296] failed (but getting better)
"marcel" has given AR/Oracle some love, but it''s still
unhappy...
http://dev.rubyonrails.org/changeset/4296
------------------------------------------------------------------------
r4296 | marcel | 2006-04-27 17:56:15 -0700 (Thu, 27 Apr 2006) | 1 line
Only modify the sequence name in the FrontBase adapter if the FrontBase adapter
is actually being used. [Marcel Molina Jr.]
------------------------------------------------------------------------
U activerecord/lib/active_record/connection_adapters/frontbase_adapter.rb
U activerecord/CHANGELOG
Updated to revision 4296.
1) Error:
test_should_calculate_grouped_by_function(CalculationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-00904: "UPPER_TYPE":
invalid identifier: SELECT count(*) AS count_all, UPPER(type) AS upper_type FROM
companies GROUP BY upper_type
./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
./test/../lib/active_record/calculations.rb:207:in
`execute_grouped_calculation''
./test/../lib/active_record/calculations.rb:119:in `calculate''
./test/../lib/active_record/calculations.rb:117:in `calculate''
./test/../lib/active_record/calculations.rb:45:in `count''
./test/calculations_test.rb:136:in
`test_should_calculate_grouped_by_function''
2) Error:
test_should_calculate_grouped_by_function_with_table_alias(CalculationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-00904:
"UPPER_COMPANIES_TYPE": invalid identifier: SELECT count(*) AS
count_all, UPPER(companies.type) AS upper_companies_type FROM companies GROUP
BY upper_companies_type
./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
./test/../lib/active_record/calculations.rb:207:in
`execute_grouped_calculation''
./test/../lib/active_record/calculations.rb:119:in `calculate''
./test/../lib/active_record/calculations.rb:117:in `calculate''
./test/../lib/active_record/calculations.rb:45:in `count''
./test/calculations_test.rb:144:in
`test_should_calculate_grouped_by_function_with_table_alias''
3) Error:
test_should_calculate_grouped_with_invalid_field(CalculationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-00904:
"ACCOUNTS_FIRM_ID": invalid identifier: SELECT count(*) AS count_all,
accounts.firm_id AS accounts_firm_id FROM accounts GROUP BY accounts_firm_id
./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
./test/../lib/active_record/calculations.rb:207:in
`execute_grouped_calculation''
./test/../lib/active_record/calculations.rb:119:in `calculate''
./test/../lib/active_record/calculations.rb:117:in `calculate''
./test/../lib/active_record/calculations.rb:45:in `count''
./test/calculations_test.rb:122:in
`test_should_calculate_grouped_with_invalid_field''
4) Error:
test_should_group_by_fields_with_table_alias(CalculationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-00904:
"ACCOUNTS_FIRM_ID": invalid identifier: SELECT sum(credit_limit) AS
sum_credit_limit, accounts.firm_id AS accounts_firm_id FROM accounts GROUP BY
accounts_firm_id
./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
./test/../lib/active_record/calculations.rb:207:in
`execute_grouped_calculation''
./test/../lib/active_record/calculations.rb:119:in `calculate''
./test/../lib/active_record/calculations.rb:117:in `calculate''
./test/../lib/active_record/calculations.rb:73:in `sum''
./test/calculations_test.rb:110:in
`test_should_group_by_fields_with_table_alias''
865 tests, 3052 assertions, 0 failures, 4 errors
rake aborted!
Command failed with status (1): [/usr/pkg/ruby184/bin/ruby -Ilib:test:test/...]
(See full trace by running task with --trace)
Marcel Molina Jr.
2006-Apr-28 01:31 UTC
Re: Rails AR/Oracle Unit Test: [4296] failed (but getting better)
On Thu, Apr 27, 2006 at 06:02:00PM -0700, Michael Schoen wrote:> "marcel" has given AR/Oracle some love, but it''s still unhappy... > > http://dev.rubyonrails.org/changeset/4296 > ------------------------------------------------------------------------ > r4296 | marcel | 2006-04-27 17:56:15 -0700 (Thu, 27 Apr 2006) | 1 line > > Only modify the sequence name in the FrontBase adapter if the FrontBase adapter is actually being used. [Marcel Molina Jr.] > ------------------------------------------------------------------------ > > U activerecord/lib/active_record/connection_adapters/frontbase_adapter.rb > U activerecord/CHANGELOG > Updated to revision 4296. > > 1) Error: > test_should_calculate_grouped_by_function(CalculationsTest): > ActiveRecord::StatementInvalid: OCIError: ORA-00904: "UPPER_TYPE": invalid identifier: SELECT count(*) AS count_all, UPPER(type) AS upper_type FROM companies GROUP BY upper_typeI believe I''ve fixed this one too. Sorry to those on the rails core list who could care less about Oracle ;) I think we are close to fixing it, if not there. It''s curious that all the tests passed on mysql, postgresql and sqlite but failed with oracle. marcel -- Marcel Molina Jr. <marcel@vernix.org>
Scott Barron
2006-Apr-28 01:35 UTC
Re: Rails AR/Oracle Unit Test: [4296] failed (but getting better)
On Apr 27, 2006, at 9:31 PM, Marcel Molina Jr. wrote:> On Thu, Apr 27, 2006 at 06:02:00PM -0700, Michael Schoen wrote: > >> "marcel" has given AR/Oracle some love, but it''s still unhappy... >> >> http://dev.rubyonrails.org/changeset/4296 >> --------------------------------------------------------------------- >> --- >> r4296 | marcel | 2006-04-27 17:56:15 -0700 (Thu, 27 Apr 2006) | 1 >> line >> >> Only modify the sequence name in the FrontBase adapter if the >> FrontBase adapter is actually being used. [Marcel Molina Jr.] >> --------------------------------------------------------------------- >> --- >> >> U activerecord/lib/active_record/connection_adapters/ >> frontbase_adapter.rb >> U activerecord/CHANGELOG >> Updated to revision 4296. >> >> 1) Error: >> test_should_calculate_grouped_by_function(CalculationsTest): >> ActiveRecord::StatementInvalid: OCIError: ORA-00904: "UPPER_TYPE": >> invalid identifier: SELECT count(*) AS count_all, UPPER(type) AS >> upper_type FROM companies GROUP BY upper_type >> > > I believe I''ve fixed this one too. Sorry to those on the rails core > list who > could care less about Oracle ;) I think we are close to fixing it, > if not > there.I think it''s cool, I''d like to see this system for all the rails components. Very handy. -Scott