Rails core - Apr 2006 - Rails AR/Oracle Unit Test: [4293] failed (getting worse)

"marcel" has kicked AR/Oracle while it was down...

http://dev.rubyonrails.org/changeset/4293
------------------------------------------------------------------------
r4293 | marcel | 2006-04-27 15:54:34 -0700 (Thu, 27 Apr 2006) | 1 line

Don''t require the frontbase adapter until you need to
------------------------------------------------------------------------

U  activerecord/lib/active_record/connection_adapters/frontbase_adapter.rb
Updated to revision 4293.

  1) Error:
test_force_reload(AssociationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not exist:
select companies_seq.nextval id from dual
    ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:266:in
`select_one''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:280:in
`insert''
    ./test/../lib/active_record/base.rb:1748:in
`create_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:261:in
`create_without_timestamps''
    ./test/../lib/active_record/timestamp.rb:30:in `create''
    ./test/../lib/active_record/base.rb:1727:in
`create_or_update_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:249:in `create_or_update''
    ./test/../lib/active_record/base.rb:1401:in
`save_without_validation''
    ./test/../lib/active_record/validations.rb:749:in
`save_without_transactions''
    ./test/../lib/active_record/transactions.rb:126:in `save''
   
./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:51:in
`transaction''
    ./test/../lib/active_record/transactions.rb:91:in `transaction''
    ./test/../lib/active_record/transactions.rb:118:in `transaction''
    ./test/../lib/active_record/transactions.rb:126:in `save''
    ./test/associations_test.rb:30:in `test_force_reload''

  2) Error:
test_storing_in_pstore(AssociationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not exist:
select companies_seq.nextval id from dual
    ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:266:in
`select_one''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:280:in
`insert''
    ./test/../lib/active_record/base.rb:1748:in
`create_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:261:in
`create_without_timestamps''
    ./test/../lib/active_record/timestamp.rb:30:in `create''
    ./test/../lib/active_record/base.rb:1727:in
`create_or_update_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:249:in `create_or_update''
    ./test/../lib/active_record/base.rb:1401:in
`save_without_validation''
    ./test/../lib/active_record/validations.rb:749:in
`save_without_transactions''
    ./test/../lib/active_record/transactions.rb:126:in `save''
   
./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:51:in
`transaction''
    ./test/../lib/active_record/transactions.rb:91:in `transaction''
    ./test/../lib/active_record/transactions.rb:118:in `transaction''
    ./test/../lib/active_record/transactions.rb:126:in `save''
    ./test/../lib/active_record/base.rb:408:in `create''
    ./test/associations_test.rb:52:in `test_storing_in_pstore''

  3) Error:
test_assignment_before_child_saved(BelongsToAssociationsTest):
ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not exist:
select companies_seq.nextval id from dual
    ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in
`log''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:271:in
`execute''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:473:in
`select''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:262:in
`select_all''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:266:in
`select_one''
    ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:280:in
`insert''
    ./test/../lib/active_record/base.rb:1748:in
`create_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:261:in
`create_without_timestamps''
    ./test/../lib/active_record/timestamp.rb:30:in `create''
    ./test/../lib/active_record/base.rb:1727:in
`create_or_update_without_callbacks''
    ./test/../lib/active_record/callbacks.rb:249:in `create_or_update''
    ./test/../lib/active_record/base.rb:1401:in
`save_without_validation''
    ./test/../lib/active_record/validations.rb:749:in
`save_without_transactions''
    ./test/../lib/active_record/transactions.rb:126:in `save''
   
./test/../lib/active_record/connection_adapters/abstract/database_statements.rb:51:in
`transaction''
    ./test/../lib/active_record/transactions.rb:91:in `transaction''
    ./test/../lib/active_record/transactions.rb:118:in `transaction''
    ./test/../lib/active_record/transactions.rb:126:in `save''
    ./test/associations_test.rb:918:

On Thu, Apr 27, 2006 at 03:56:56PM -0700, Michael Schoen
wrote:
>   1) Error:
> test_force_reload(AssociationsTest):
> ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not
exist: select companies_seq.nextval id from dual
> 
>   2) Error:
> test_storing_in_pstore(AssociationsTest):
> ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not
exist: select companies_seq.nextval id from dual
>
>   3) Error:
> test_assignment_before_child_saved(BelongsToAssociationsTest):
> ActiveRecord::StatementInvalid: OCIError: ORA-02289: sequence does not
exist: select companies_seq.nextval id from dual
Sorry to bother with this. Any idea what''s up here?

marcel
-- 
Marcel Molina Jr. <marcel@vernix.org>

Michael Schoen wrote:
> "marcel" has kicked AR/Oracle while it was down...
I think you fixed the actual frontbase problem, it''s failing now for 
some other reason -- I''m looking into it.

Michael A. Schoen wrote:
> Michael Schoen wrote:
>> "marcel" has kicked AR/Oracle while it was down...
> 
> I think you fixed the actual frontbase problem, it''s failing now
for
> some other reason -- I''m looking into it.
Hmm, it is still something about frontbase that''s breaking it, not
quite
sure what yet. But if I change activerecord.rb to not include frontbase, 
the errors go away.

Michael A. Schoen wrote:
> Michael A. Schoen wrote:
>> Michael Schoen wrote:
>>> "marcel" has kicked AR/Oracle while it was down...
>>
>> I think you fixed the actual frontbase problem, it''s failing
now for
>> some other reason -- I''m looking into it.
> 
> Hmm, it is still something about frontbase that''s breaking it, not
quite
> sure what yet. But if I change activerecord.rb to not include frontbase, 
> the errors go away.
Ok, found the issue -- it is a real issue w/ the frontbase adapter, in 
that it redefines #set_sequence_name to do nothing. That seems wrong and 
unnecessary. Can you remove those 2 lines?

module ActiveRecord
   class Base
     class << self
       # FrontBase only supports one unnamed sequence per table
       def set_sequence_name( value=nil, &block )
       end

On Thu, Apr 27, 2006 at 05:12:40PM -0700, Michael A. Schoen
wrote:
> Michael A. Schoen wrote:
> >Michael A. Schoen wrote:
> >>Michael Schoen wrote:
> >>>"marcel" has kicked AR/Oracle while it was down...
> >>
> >>I think you fixed the actual frontbase problem, it''s
failing now for
> >>some other reason -- I''m looking into it.
> >
> >Hmm, it is still something about frontbase that''s breaking it,
not quite
> >sure what yet. But if I change activerecord.rb to not include
frontbase,
> >the errors go away.
> 
> Ok, found the issue -- it is a real issue w/ the frontbase adapter, in 
> that it redefines #set_sequence_name to do nothing. That seems wrong and 
> unnecessary. Can you remove those 2 lines?
> 
> module ActiveRecord
>   class Base
>     class << self
>       # FrontBase only supports one unnamed sequence per table
>       def set_sequence_name( value=nil, &block )
>       end
The FrontBase adapter apparently requires that this be the case. I''m
currently trying to redefine it only in the case where the FrontBase adapter
is the current adapter which is tricky since the connection isn''t setup
yet.

marcel
-- 
Marcel Molina Jr. <marcel@vernix.org>

On Thu, Apr 27, 2006 at 05:12:40PM -0700, Michael A. Schoen
wrote:
> Michael A. Schoen wrote:
> >Michael A. Schoen wrote:
> >>Michael Schoen wrote:
> >>>"marcel" has kicked AR/Oracle while it was down...
> >>
> >>I think you fixed the actual frontbase problem, it''s
failing now for
> >>some other reason -- I''m looking into it.
> >
> >Hmm, it is still something about frontbase that''s breaking it,
not quite
> >sure what yet. But if I change activerecord.rb to not include
frontbase,
> >the errors go away.
> 
> Ok, found the issue -- it is a real issue w/ the frontbase adapter, in 
> that it redefines #set_sequence_name to do nothing. That seems wrong and 
> unnecessary. Can you remove those 2 lines?
> 
> module ActiveRecord
>   class Base
>     class << self
>       # FrontBase only supports one unnamed sequence per table
>       def set_sequence_name( value=nil, &block )
>       end
I believe I''ve fixed this (with a bit of a hack) though I
don''t yet see the
Oracle CI system letting me know that things are alright now. When the
original author of the adapter reemerges perhaps he can provide a more
elegant solution. In any event, thanks for doing the leg work in figuring out
what was the culprit Michael. Let''s see if what I did sticks.

marcel
-- 
Marcel Molina Jr. <marcel@vernix.org>