I''m one of the developers on the Subversion project that has full commit rights and I''m thinking that to help portions of Rails move a little faster, say in the database adapters, that the core Rails team look at offering partial commit rights to people for small portions of the code base. This would be a half-way step between no access and somebody who clearly understands the direction and the entire code base. Our current list is in svn at: http://svn.collab.net/repos/svn/trunk/COMMITTERS It would be nice if the people like Michael Schoen who have shown a commitment to the Oracle bindings could work on that portion without the overhead of a full time committer reviewing each commit, as long as only that file or file(s) is modified. On the Subversion team, we have a private mailing list to discuss invitations and other issues (which is not archived if somebody does become a full committer later on, so they can''t see the discussion that took place around them.) We don''t actually enforce the protections on the partial committers via an authorization method, as people are pretty good not to do commits where they were not offered commit access, and an email and a svn reverse merge is enough to undo a change. Finally, we have the "obvious fix" rule: "Any committer, whether full or partial, may commit fixes for obvious typos, grammar mistakes, and formatting problems wherever they may be — in the web pages, API documentation, code comments, commit messages, etc. We rely on the committers judgement to determine what is "obvious"; if you''re not sure, just ask." http://subversion.tigris.org/hacking.html Some ideas to consider. Regards, Blair -- Blair Zajac, Ph.D. <blair@orcaware.com> Subversion training, consulting and support http://www.orcaware.com/svn/
On 6/5/06, Blair Zajac <blair@orcaware.com> wrote:> I''m one of the developers on the Subversion project that has full commit rights > and I''m thinking that to help portions of Rails move a little faster, say in the > database adapters, that the core Rails team look at offering partial commit > rights to people for small portions of the code base. This would be a half-way > step between no access and somebody who clearly understands the direction and > the entire code base.[snip] This is a great idea; it would take the burden off of the full-access committers. This is especially true for things like the Oracle adapter, since most of the regular committers don''t have access to an Oracle db on which to test submitted patches. Their ''review'' wouldn''t be too comprehensive, then :) Generally, people who would even be considered for commit access would be responsible enough to only commit to the areas that they''ve been explicitly given access to. I can''t see any issues with this... Besides, there''s always ''svn revert'' :) Dave -- Dave Goodlad dgoodlad@gmail.com or dave@goodlad.ca http://david.goodlad.ca/
> It would be nice if the people like Michael Schoen who have shown a commitment > to the Oracle bindings could work on that portion without the overhead of a full > time committer reviewing each commit, as long as only that file or file(s) is > modified.I like the idea for database adapters, but I don''t see it being all that useful outside of that. Other areas where you''d think this would be a good fit? -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
On 6/13/06, David Heinemeier Hansson <david.heinemeier@gmail.com> wrote:> > It would be nice if the people like Michael Schoen who have shown a commitment > > to the Oracle bindings could work on that portion without the overhead of a full > > time committer reviewing each commit, as long as only that file or file(s) is > > modified. > > I like the idea for database adapters, but I don''t see it being all > that useful outside of that. Other areas where you''d think this would > be a good fit?It would be great if either Ryan Tomayko or myself could commit changes to fix the SQL Server adapter. Restricting access to just the adapter file would be a mistake though; many patches involve additional tests or changes to existing tests, so if access were granted at all it should include the test directory. Tom
I was thinking the same thing in regards to the db adapters but limited to the adapters that core members do not test against or have access to. The only other part of rails I could imagine would be the web services if someone wants to take responsibility for maintaining that. Bob Silva http://i.nfectio.us> -----Original Message----- > From: rails-core-bounces@lists.rubyonrails.org [mailto:rails-core- > bounces@lists.rubyonrails.org] On Behalf Of David Heinemeier Hansson > Sent: Tuesday, June 13, 2006 3:00 AM > To: rails-core@lists.rubyonrails.org > Subject: Re: [Rails-core] [PROPOSAL] Partial commit access > > > It would be nice if the people like Michael Schoen who have shown a > commitment > > to the Oracle bindings could work on that portion without the overhead > of a full > > time committer reviewing each commit, as long as only that file or > file(s) is > > modified. > > I like the idea for database adapters, but I don''t see it being all > that useful outside of that. Other areas where you''d think this would > be a good fit? > -- > David Heinemeier Hansson > http://www.loudthinking.com -- Broadcasting Brain > http://www.basecamphq.com -- Online project management > http://www.backpackit.com -- Personal information manager > http://www.rubyonrails.com -- Web-application framework > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core
On Jun 13, 2006, at 3:00 AM, David Heinemeier Hansson wrote:>> It would be nice if the people like Michael Schoen who have shown >> a commitment >> to the Oracle bindings could work on that portion without the >> overhead of a full >> time committer reviewing each commit, as long as only that file or >> file(s) is >> modified. > > I like the idea for database adapters, but I don''t see it being all > that useful outside of that. Other areas where you''d think this would > be a good fit?None right now, but getting the commit rights for people who maintain the database adaptors would be nice. Regards, Blair -- Blair Zajac, Ph.D. <blair@orcaware.com> Subversion training, consulting and support http://www.orcaware.com/svn/