Florian Bruhin
2013-Nov-26 08:56 UTC
[Nut-upsdev] [PATCH] Add OptiUPS VS 575C support to PowerCom
Heya, after I bought an OptiUPS VS 575C and discovering it won't work with Linux (silly me) I sniffed the protocol, found out it's very similiar to the protocol in the powercom driver, so I ended up adding support for that UPS to that driver. The patch is against the current git HEAD and works fine for me since weeks now. The shutdown sequence also works fine (on Archlinux). This is my first contribution and I gave my best to read the developer documentation and do sensible changes everywhere required, but if I missed anything or anything can be improved, please let me know! upsc output: battery.charge: 100.0 device.mfr: PowerCom device.model: OPTI-575 device.serial: Unknown device.type: ups driver.name: powercom driver.parameter.pollinterval: 2 driver.parameter.port: /dev/ttyUSB0 driver.parameter.type: OPTI driver.version: 2.7.1-signed-8-gb11d66f driver.version.internal: 0.14 input.frequency: 50.00 input.voltage: 224.0 input.voltage.nominal: 230 output.frequency: 50.00 output.voltage: 224.0 ups.load: 0.0 ups.mfr: PowerCom ups.model: OPTI-575 ups.model.type: OPTI ups.serial: Unknown ups.status: OL Florian -- () ascii ribbon campaign - stop html mail www.asciiribbon.org /\ www.the-compiler.org | I love long mails http://email.is-not-s.ms/ <Espy> tomorrow there will be a great disturbance in the workforce -- May 18, 1999 -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-OptiUPS-support-in-powercom-driver.patch Type: text/x-diff Size: 8837 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20131126/c717137d/attachment.patch> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20131126/c717137d/attachment.sig>
Charles Lepple
2013-Dec-23 04:56 UTC
[Nut-upsdev] [PATCH] Add OptiUPS VS 575C support to PowerCom
On Nov 26, 2013, at 3:56 AM, Florian Bruhin wrote:> This is my first contribution and I gave my best to read the developer > documentation and do sensible changes everywhere required, but if I > missed anything or anything can be improved, please let me know!I apologize for sitting on this for so long - I downloaded the patch, didn't see much that needed to be changed, but forgot to commit it. The one addition was adding an entry to data/driver.list.in. Depending on how common these devices are relative to the other Opti-UPS models, we might also want to add a comment to the optiups driver man page indicating that this model (and possibly others?) are covered by the powercom driver. Merged - thanks! -- Charles Lepple clepple at gmail