Tom Rix
2022-Apr-18 14:18 UTC
[Nouveau] [PATCH] drm/nouveau: change base917c_format from global to static
Smatch reports this issue base917c.c:26:1: warning: symbol 'base917c_format' was not declared. Should it be static? base917c_format is only used in base917.c. Single file variables should not be global so change base917c_format's storage-class specifier to static. Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/base917c.c b/drivers/gpu/drm/nouveau/dispnv50/base917c.c index a1baed4fe0e9..ca260509a4f1 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/base917c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base917c.c @@ -22,7 +22,7 @@ #include "base.h" #include "atom.h" -const u32 +static const u32 base917c_format[] = { DRM_FORMAT_C8, DRM_FORMAT_XRGB8888, -- 2.27.0
Lyude Paul
2022-Apr-18 18:41 UTC
[Nouveau] [PATCH] drm/nouveau: change base917c_format from global to static
Reviewed-by: Lyude Paul <lyude at redhat.com> Will push this to the appropriate branch in a little bit On Mon, 2022-04-18 at 10:18 -0400, Tom Rix wrote:> Smatch reports this issue > base917c.c:26:1: warning: symbol 'base917c_format' > ? was not declared. Should it be static? > > base917c_format is only used in base917.c.? Single > file variables should not be global so change > base917c_format's storage-class specifier to static. > > Signed-off-by: Tom Rix <trix at redhat.com> > --- > ?drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +- > ?1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/base917c.c > b/drivers/gpu/drm/nouveau/dispnv50/base917c.c > index a1baed4fe0e9..ca260509a4f1 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/base917c.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/base917c.c > @@ -22,7 +22,7 @@ > ?#include "base.h" > ?#include "atom.h" > ? > -const u32 > +static const u32 > ?base917c_format[] = { > ????????DRM_FORMAT_C8, > ????????DRM_FORMAT_XRGB8888,-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat