Marcin Slusarz
2012-Apr-15 12:36 UTC
[Nouveau] [PATCH resend] drm/nouveau: fix acpi related kbuild warnings
Currently when X86 && ACPI && !X86_PLATFORM_DEVICES kbuild spits: warning: (DRM_NOUVEAU) selects ACPI_WMI which has unmet direct dependencies (X86 && X86_PLATFORM_DEVICES && ACPI) warning: (DRM_NOUVEAU) selects MXM_WMI which has unmet direct dependencies (X86 && X86_PLATFORM_DEVICES && ACPI_WMI) and goes on, which leaves a situation where ACPI_WMI (which depends on X86_PLATFORM_DEVICES) is enabled but X86_PLATFORM_DEVICES is not. Additionally, Nouveau on IA64 would enable these X86-related drivers when ACPI is enabled (doesn't matter but is wrong) and build nouveau_acpi.c which depends on them. To fix this, introduce hidden DRM_NOUVEAU_ACPI variable which selects all acpi/x86 related configs and select it when both X86 and ACPI are enabled. Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com> --- drivers/gpu/drm/nouveau/Kconfig | 9 +++++++-- drivers/gpu/drm/nouveau/Makefile | 2 +- drivers/gpu/drm/nouveau/nouveau_drv.h | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index 97a8126..5648640 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -11,12 +11,17 @@ config DRM_NOUVEAU select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT - select ACPI_WMI if ACPI - select MXM_WMI if ACPI + select DRM_NOUVEAU_ACPI if ACPI && X86 select POWER_SUPPLY help Choose this option for open-source nVidia support. +config DRM_NOUVEAU_ACPI + bool + select X86_PLATFORM_DEVICES + select ACPI_WMI + select MXM_WMI + config DRM_NOUVEAU_BACKLIGHT bool "Support for backlight control" depends on DRM_NOUVEAU diff --git a/drivers/gpu/drm/nouveau/Makefile b/drivers/gpu/drm/nouveau/Makefile index 297709e..03860f5 100644 --- a/drivers/gpu/drm/nouveau/Makefile +++ b/drivers/gpu/drm/nouveau/Makefile @@ -43,6 +43,6 @@ nouveau-y := nouveau_drv.o nouveau_state.o nouveau_channel.o nouveau_mem.o \ nouveau-$(CONFIG_DRM_NOUVEAU_DEBUG) += nouveau_debugfs.o nouveau_vram_con.o nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o nouveau-$(CONFIG_DRM_NOUVEAU_BACKLIGHT) += nouveau_backlight.o -nouveau-$(CONFIG_ACPI) += nouveau_acpi.o +nouveau-$(CONFIG_DRM_NOUVEAU_ACPI) += nouveau_acpi.o obj-$(CONFIG_DRM_NOUVEAU)+= nouveau.o diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h index d72bb1f..fad07cc 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drv.h +++ b/drivers/gpu/drm/nouveau/nouveau_drv.h @@ -1097,7 +1097,7 @@ extern int nouveau_dma_wait(struct nouveau_channel *, int slots, int size); /* nouveau_acpi.c */ #define ROM_BIOS_PAGE 4096 -#if defined(CONFIG_ACPI) +#if defined(CONFIG_DRM_NOUVEAU_ACPI) void nouveau_register_dsm_handler(void); void nouveau_unregister_dsm_handler(void); void nouveau_switcheroo_optimus_dsm(void); -- 1.7.8.5
Marcin Slusarz
2012-May-27 19:58 UTC
[Nouveau] [PATCH resend] drm/nouveau: fix acpi related kbuild warnings
On Sun, Apr 15, 2012 at 02:36:06PM +0200, Marcin Slusarz wrote:> Currently when X86 && ACPI && !X86_PLATFORM_DEVICES kbuild spits: > > warning: (DRM_NOUVEAU) selects ACPI_WMI which has unmet direct > dependencies (X86 && X86_PLATFORM_DEVICES && ACPI) > warning: (DRM_NOUVEAU) selects MXM_WMI which has unmet direct > dependencies (X86 && X86_PLATFORM_DEVICES && ACPI_WMI) > > and goes on, which leaves a situation where ACPI_WMI (which depends on > X86_PLATFORM_DEVICES) is enabled but X86_PLATFORM_DEVICES is not. > Additionally, Nouveau on IA64 would enable these X86-related drivers > when ACPI is enabled (doesn't matter but is wrong) and build > nouveau_acpi.c which depends on them. > > To fix this, introduce hidden DRM_NOUVEAU_ACPI variable which selects > all acpi/x86 related configs and select it when both X86 and ACPI are > enabled. > > Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com> > ---What's up with this patch? Marcin
Reasonably Related Threads
- [PATCH] drm/nouveau: fix acpi related kbuild warnings
- [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies
- [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal
- [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it
- [PATCH v4 06/10] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends